You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Erik Huelsmann <e....@gmx.net> on 2005/10/06 10:51:51 UTC

Re: svn commit: r16481 - in branches/wc-replacements/subversion: include

> Modified:
>    branches/wc-replacements/subversion/include/svn_wc.h
>    branches/wc-replacements/subversion/libsvn_wc/copy.c
>    branches/wc-replacements/subversion/libsvn_wc/update_editor.c
> 
> Log:
> Make svn cp PATH PATH loggy.
> 
> * subversion/include/svn_wc.h
>   (svn_wc_add_repos_file2): Revv svn_wc_add_repos_file().
>   (svn_wc_add_repos_file): Deprecate.

s/Revv/Rev/

 
> * subversion/libsvn_wc/copy.c
>   (copy_file_administratively): Use svn_wc_add_repos_file2() instead
>   of svn_wc_add2().
> 
> * subversion/libsvn_wc/update_editor.c
>   (svn_wc_add_repos_file2): Revv svn_wc_add_repos_file(). Install new

s/Revv/Rev/

>   working text and props if given.
>   (svn_wc_add_repos_file): Deprecate. Call svn_wc_add_repos_file2()
>   with NULL new_text_path and new_props arguments.

There are other locations where svn_wc_add_repos_file is called. Those
should be updated too, since it is now deprecated (not meant to be used
anymore). If you don't have time to do that, I'll try doing it tonight.
Normally, you can use http://hix.nu/subversion/lxr/source for finding cross
references. Unfortunatly, yesterday, I took it down for maintenance (and
it's not back up yet).

The change looks good, but there's one problem: one test now fails within
copy_tests.py: the one which tests for copying of the executable bit on
unix. That too will probably need to be an issue for tonight (for me).

bye,


Erik.

-- 
5 GB Mailbox, 50 FreeSMS http://www.gmx.net/de/go/promail
+++ GMX - die erste Adresse f�r Mail, Message, More +++

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r16481 - in branches/wc-replacements/subversion: include

Posted by Ivan Zhakov <ch...@gmail.com>.
On 10/6/05, Erik Huelsmann <e....@gmx.net> wrote:
>
> > Modified:
> >    branches/wc-replacements/subversion/include/svn_wc.h
> >    branches/wc-replacements/subversion/libsvn_wc/copy.c
> >    branches/wc-replacements/subversion/libsvn_wc/update_editor.c
> >
> > Log:
> > Make svn cp PATH PATH loggy.
> >
> > * subversion/include/svn_wc.h
> >   (svn_wc_add_repos_file2): Revv svn_wc_add_repos_file().
> >   (svn_wc_add_repos_file): Deprecate.
>
> s/Revv/Rev/
Fixed.

> > * subversion/libsvn_wc/copy.c
> >   (copy_file_administratively): Use svn_wc_add_repos_file2() instead
> >   of svn_wc_add2().
> >
> > * subversion/libsvn_wc/update_editor.c
> >   (svn_wc_add_repos_file2): Revv svn_wc_add_repos_file(). Install new
>
> s/Revv/Rev/
Fixed.

> There are other locations where svn_wc_add_repos_file is called. Those
> should be updated too, since it is now deprecated (not meant to be used
> anymore). If you don't have time to do that, I'll try doing it tonight.
> Normally, you can use http://hix.nu/subversion/lxr/source for finding cross
> references. Unfortunatly, yesterday, I took it down for maintenance (and
> it's not back up yet).
Sorry, I have no time today and most likely tomorow for this.

> The change looks good, but there's one problem: one test now fails within
> copy_tests.py: the one which tests for copying of the executable bit on
> unix. That too will probably need to be an issue for tonight (for me).
Oops. On my Windows desktop this test was skipped, therefore I cannot
check and fix this  issue.

--
Ivan Zhakov