You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2017/05/30 23:17:27 UTC

Review Request 59666: Moved Framework::addTask to the source file.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59666/
-----------------------------------------------------------

Review request for mesos, Anand Mazumdar and Vinod Kone.


Repository: mesos


Description
-------

Moved Framework::addTask to the source file.


Diffs
-----

  src/slave/slave.hpp 77fb93abc701cd34b69c75b6219c219fdb784a67 
  src/slave/slave.cpp 055e4967a4c820d7835f5fecdc46f82eaddd9117 


Diff: https://reviews.apache.org/r/59666/diff/1/


Testing
-------

make check


Thanks,

Jie Yu

Re: Review Request 59666: Moved Framework::addTask to the source file.

Posted by Jie Yu <yu...@gmail.com>.


> On May 31, 2017, 4:45 p.m., Anand Mazumdar wrote:
> > src/slave/slave.hpp
> > Lines 868 (patched)
> > <https://reviews.apache.org/r/59666/diff/1/?file=1735079#file1735079line868>
> >
> >     Update the summary/description to `hasTask()` instead of `addTask()`?

Fixed. Good catch.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59666/#review176471
-----------------------------------------------------------


On May 30, 2017, 11:17 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59666/
> -----------------------------------------------------------
> 
> (Updated May 30, 2017, 11:17 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moved Framework::addTask to the source file.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp 77fb93abc701cd34b69c75b6219c219fdb784a67 
>   src/slave/slave.cpp 055e4967a4c820d7835f5fecdc46f82eaddd9117 
> 
> 
> Diff: https://reviews.apache.org/r/59666/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 59666: Moved Framework::addTask to the source file.

Posted by Anand Mazumdar <an...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59666/#review176471
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/slave.hpp
Lines 868 (patched)
<https://reviews.apache.org/r/59666/#comment249827>

    Update the summary/description to `hasTask()` instead of `addTask()`?


- Anand Mazumdar


On May 30, 2017, 11:17 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59666/
> -----------------------------------------------------------
> 
> (Updated May 30, 2017, 11:17 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moved Framework::addTask to the source file.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp 77fb93abc701cd34b69c75b6219c219fdb784a67 
>   src/slave/slave.cpp 055e4967a4c820d7835f5fecdc46f82eaddd9117 
> 
> 
> Diff: https://reviews.apache.org/r/59666/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>