You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by tgroh <gi...@git.apache.org> on 2016/04/11 23:28:18 UTC

[GitHub] incubator-beam pull request: Select the runner in spark SparkPipel...

GitHub user tgroh opened a pull request:

    https://github.com/apache/incubator-beam/pull/167

    Select the runner in spark SparkPipelineOptionsFactory

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace "<Jira issue #>" in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    The SparkPipelineOptionsFactory should ensure that the returned options
    have Spark as the PipelineRunner.
    
    Use the SparkPipelineOptionsFactory in the spark TfIdf test
    
    Without using the SparkPipelineRunner explicitly, the Pipeline run with
    the SparkRunner may have an unexpected graph due to runner-specific
    interceptions of the Pipeline#apply method

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam spark_options_runner_choice

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/167.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #167
    
----
commit 348a63f4bd8d809c8e4a5dce2d74964daa5ee86e
Author: Thomas Groh <tg...@google.com>
Date:   2016-04-11T20:58:59Z

    Select the runner in spark SparkPipelineOptionsFactory
    
    The SparkPipelineOptionsFactory should ensure that the returned options
    have Spark as the PipelineRunner.
    
    Use the SparkPipelineOptionsFactory in the spark TfIdf test
    
    Without using the SparkPipelineRunner explicitly, the Pipeline run with
    the SparkRunner may have an unexpected graph due to runner-specific
    interceptions of the Pipeline#apply method

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-beam pull request: Remove SparkPipelineOptionsFactory, S...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-beam/pull/167


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---