You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Vineet Garg <vg...@hortonworks.com> on 2016/10/10 21:48:23 UTC
Review Request 52708: HIVE-14913 Moved system tests to unit tests
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52708/
-----------------------------------------------------------
Review request for hive and Ashutosh Chauhan.
Bugs: HIVE-14913
https://issues.apache.org/jira/browse/HIVE-14913
Repository: hive-git
Description
-------
Moved bunch of system tests to hive unit tests
Diffs
-----
itests/src/test/resources/testconfiguration.properties fbba0cd
ql/src/test/queries/clientpositive/acid_globallimit.q 7fa4c07
ql/src/test/queries/clientpositive/alter_merge_orc.q aac98a8
ql/src/test/queries/clientpositive/cte_1.q ca4132f
ql/src/test/queries/clientpositive/cte_2.q b49620a
ql/src/test/queries/clientpositive/current_date_timestamp.q 9bed885
ql/src/test/queries/clientpositive/insert1.q 4117b54
ql/src/test/queries/clientpositive/join_acid_non_acid.q 866b466
ql/src/test/queries/clientpositive/lvj_mapjoin.q b726e2a
ql/src/test/queries/clientpositive/orc_ppd_basic.q 43f2c85
ql/src/test/queries/clientpositive/vectorization_0.q caa6a6a
ql/src/test/queries/clientpositive/windowing_gby.q e1a536b
ql/src/test/results/clientpositive/acid_globallimit.q.out fe738a6
ql/src/test/results/clientpositive/alter_merge_orc.q.out b5a6d04
ql/src/test/results/clientpositive/cte_1.q.out 6e7acf6
ql/src/test/results/clientpositive/cte_2.q.out 4b0bc71
ql/src/test/results/clientpositive/current_date_timestamp.q.out 9c26095
ql/src/test/results/clientpositive/insert1.q.out 7a2c429
ql/src/test/results/clientpositive/llap/acid_globallimit.q.out 6f0e46e
ql/src/test/results/clientpositive/llap/alter_merge_orc.q.out b5a6d04
ql/src/test/results/clientpositive/llap/cte_1.q.out 41ffdc7
ql/src/test/results/clientpositive/llap/cte_2.q.out 017bded
ql/src/test/results/clientpositive/llap/current_date_timestamp.q.out PRE-CREATION
ql/src/test/results/clientpositive/llap/insert1.q.out 4b30156
ql/src/test/results/clientpositive/llap/join_acid_non_acid.q.out 4905351
ql/src/test/results/clientpositive/llap/lvj_mapjoin.q.out dd4d024
ql/src/test/results/clientpositive/llap/orc_ppd_basic.q.out aa37ff3
ql/src/test/results/clientpositive/llap/vectorization_0.q.out faceb5c
ql/src/test/results/clientpositive/llap/windowing_gby.q.out a31a4b2
ql/src/test/results/clientpositive/spark/alter_merge_orc.q.out b5a6d04
ql/src/test/results/clientpositive/spark/vectorization_0.q.out 22fe7cd
ql/src/test/results/clientpositive/vectorization_0.q.out ac33721
Diff: https://reviews.apache.org/r/52708/diff/
Testing
-------
Pre-commit testing
Thanks,
Vineet Garg
Re: Review Request 52708: HIVE-14913 Moved system tests to unit tests
Posted by Vineet Garg <vg...@hortonworks.com>.
> On Oct. 18, 2016, 6:58 p.m., Ashutosh Chauhan wrote:
> > ql/src/test/queries/clientpositive/acid_globallimit.q, line 16
> > <https://reviews.apache.org/r/52708/diff/1/?file=1529998#file1529998line16>
> >
> > Worth keeping this second query.
Added this in acid_table_stats
> On Oct. 18, 2016, 6:58 p.m., Ashutosh Chauhan wrote:
> > ql/src/test/queries/clientpositive/orc_ppd_basic.q, lines 216-221
> > <https://reviews.apache.org/r/52708/diff/1-2/?file=1530006#file1530006line216>
> >
> > Aren't these tests repeated?
Yes my bad. I missed removing these after getting rid of hive.optimize.index.filter conf
> On Oct. 18, 2016, 6:58 p.m., Ashutosh Chauhan wrote:
> > ql/src/test/queries/clientpositive/orc_ppd_basic.q, lines 240-242
> > <https://reviews.apache.org/r/52708/diff/1-2/?file=1530006#file1530006line240>
> >
> > Repeated tests.
Thanks for catching these
- Vineet
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52708/#review153119
-----------------------------------------------------------
On Oct. 18, 2016, 5:46 p.m., Vineet Garg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52708/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2016, 5:46 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Bugs: HIVE-14913
> https://issues.apache.org/jira/browse/HIVE-14913
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Moved bunch of system tests to hive unit tests
>
>
> Diffs
> -----
>
> itests/src/test/resources/testconfiguration.properties 97e310d
> ql/src/test/queries/clientpositive/cte_1.q ca4132f
> ql/src/test/queries/clientpositive/cte_2.q b49620a
> ql/src/test/queries/clientpositive/current_date_timestamp.q 9bed885
> ql/src/test/queries/clientpositive/insert1.q 4117b54
> ql/src/test/queries/clientpositive/join_acid_non_acid.q 866b466
> ql/src/test/queries/clientpositive/lvj_mapjoin.q b726e2a
> ql/src/test/queries/clientpositive/orc_ppd_basic.q 43f2c85
> ql/src/test/queries/clientpositive/schema_evol_orc_acid_part_update.q d971649
> ql/src/test/queries/clientpositive/vectorization_0.q caa6a6a
> ql/src/test/results/clientpositive/cte_1.q.out 6e7acf6
> ql/src/test/results/clientpositive/cte_2.q.out 4b0bc71
> ql/src/test/results/clientpositive/current_date_timestamp.q.out 9c26095
> ql/src/test/results/clientpositive/insert1.q.out 7a2c429
> ql/src/test/results/clientpositive/llap/cte_1.q.out 41ffdc7
> ql/src/test/results/clientpositive/llap/cte_2.q.out 017bded
> ql/src/test/results/clientpositive/llap/current_date_timestamp.q.out PRE-CREATION
> ql/src/test/results/clientpositive/llap/insert1.q.out 4b30156
> ql/src/test/results/clientpositive/llap/join_acid_non_acid.q.out 4905351
> ql/src/test/results/clientpositive/llap/lvj_mapjoin.q.out dd4d024
> ql/src/test/results/clientpositive/llap/orc_ppd_basic.q.out aa37ff3
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_part_update.q.out ed698e1
> ql/src/test/results/clientpositive/llap/vectorization_0.q.out faceb5c
> ql/src/test/results/clientpositive/spark/alter_merge_orc.q.out b5a6d04
> ql/src/test/results/clientpositive/spark/vectorization_0.q.out 22fe7cd
> ql/src/test/results/clientpositive/vectorization_0.q.out ac33721
>
> Diff: https://reviews.apache.org/r/52708/diff/
>
>
> Testing
> -------
>
> Pre-commit testing
>
>
> Thanks,
>
> Vineet Garg
>
>
Re: Review Request 52708: HIVE-14913 Moved system tests to unit tests
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52708/#review153119
-----------------------------------------------------------
ql/src/test/queries/clientpositive/acid_globallimit.q (line 16)
<https://reviews.apache.org/r/52708/#comment222430>
Worth keeping this second query.
ql/src/test/queries/clientpositive/orc_ppd_basic.q (lines 214 - 219)
<https://reviews.apache.org/r/52708/#comment222398>
Aren't these tests repeated?
ql/src/test/queries/clientpositive/orc_ppd_basic.q (lines 237 - 239)
<https://reviews.apache.org/r/52708/#comment222400>
Repeated tests.
- Ashutosh Chauhan
On Oct. 18, 2016, 5:46 p.m., Vineet Garg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52708/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2016, 5:46 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Bugs: HIVE-14913
> https://issues.apache.org/jira/browse/HIVE-14913
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Moved bunch of system tests to hive unit tests
>
>
> Diffs
> -----
>
> itests/src/test/resources/testconfiguration.properties 97e310d
> ql/src/test/queries/clientpositive/cte_1.q ca4132f
> ql/src/test/queries/clientpositive/cte_2.q b49620a
> ql/src/test/queries/clientpositive/current_date_timestamp.q 9bed885
> ql/src/test/queries/clientpositive/insert1.q 4117b54
> ql/src/test/queries/clientpositive/join_acid_non_acid.q 866b466
> ql/src/test/queries/clientpositive/lvj_mapjoin.q b726e2a
> ql/src/test/queries/clientpositive/orc_ppd_basic.q 43f2c85
> ql/src/test/queries/clientpositive/schema_evol_orc_acid_part_update.q d971649
> ql/src/test/queries/clientpositive/vectorization_0.q caa6a6a
> ql/src/test/results/clientpositive/cte_1.q.out 6e7acf6
> ql/src/test/results/clientpositive/cte_2.q.out 4b0bc71
> ql/src/test/results/clientpositive/current_date_timestamp.q.out 9c26095
> ql/src/test/results/clientpositive/insert1.q.out 7a2c429
> ql/src/test/results/clientpositive/llap/cte_1.q.out 41ffdc7
> ql/src/test/results/clientpositive/llap/cte_2.q.out 017bded
> ql/src/test/results/clientpositive/llap/current_date_timestamp.q.out PRE-CREATION
> ql/src/test/results/clientpositive/llap/insert1.q.out 4b30156
> ql/src/test/results/clientpositive/llap/join_acid_non_acid.q.out 4905351
> ql/src/test/results/clientpositive/llap/lvj_mapjoin.q.out dd4d024
> ql/src/test/results/clientpositive/llap/orc_ppd_basic.q.out aa37ff3
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_part_update.q.out ed698e1
> ql/src/test/results/clientpositive/llap/vectorization_0.q.out faceb5c
> ql/src/test/results/clientpositive/spark/alter_merge_orc.q.out b5a6d04
> ql/src/test/results/clientpositive/spark/vectorization_0.q.out 22fe7cd
> ql/src/test/results/clientpositive/vectorization_0.q.out ac33721
>
> Diff: https://reviews.apache.org/r/52708/diff/
>
>
> Testing
> -------
>
> Pre-commit testing
>
>
> Thanks,
>
> Vineet Garg
>
>
Re: Review Request 52708: HIVE-14913 Moved system tests to unit tests
Posted by Vineet Garg <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52708/
-----------------------------------------------------------
(Updated Oct. 18, 2016, 8:37 p.m.)
Review request for hive and Ashutosh Chauhan.
Bugs: HIVE-14913
https://issues.apache.org/jira/browse/HIVE-14913
Repository: hive-git
Description
-------
Moved bunch of system tests to hive unit tests
Diffs (updated)
-----
itests/src/test/resources/testconfiguration.properties 97e310d
ql/src/test/queries/clientpositive/acid_table_stats.q 23d0df4
ql/src/test/queries/clientpositive/cte_1.q ca4132f
ql/src/test/queries/clientpositive/cte_2.q b49620a
ql/src/test/queries/clientpositive/current_date_timestamp.q 9bed885
ql/src/test/queries/clientpositive/join_acid_non_acid.q 866b466
ql/src/test/queries/clientpositive/lvj_mapjoin.q b726e2a
ql/src/test/queries/clientpositive/orc_ppd_basic.q 43f2c85
ql/src/test/queries/clientpositive/schema_evol_orc_acid_part_update.q d971649
ql/src/test/queries/clientpositive/vectorization_0.q caa6a6a
ql/src/test/results/clientpositive/acid_table_stats.q.out d5c509c
ql/src/test/results/clientpositive/cte_1.q.out 6e7acf6
ql/src/test/results/clientpositive/cte_2.q.out 4b0bc71
ql/src/test/results/clientpositive/current_date_timestamp.q.out 9c26095
ql/src/test/results/clientpositive/llap/cte_1.q.out 41ffdc7
ql/src/test/results/clientpositive/llap/cte_2.q.out 017bded
ql/src/test/results/clientpositive/llap/current_date_timestamp.q.out PRE-CREATION
ql/src/test/results/clientpositive/llap/join_acid_non_acid.q.out 4905351
ql/src/test/results/clientpositive/llap/lvj_mapjoin.q.out dd4d024
ql/src/test/results/clientpositive/llap/orc_ppd_basic.q.out aa37ff3
ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_part_update.q.out ed698e1
ql/src/test/results/clientpositive/llap/vectorization_0.q.out faceb5c
ql/src/test/results/clientpositive/spark/vectorization_0.q.out 22fe7cd
ql/src/test/results/clientpositive/vectorization_0.q.out ac33721
Diff: https://reviews.apache.org/r/52708/diff/
Testing
-------
Pre-commit testing
Thanks,
Vineet Garg
Re: Review Request 52708: HIVE-14913 Moved system tests to unit tests
Posted by Vineet Garg <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52708/
-----------------------------------------------------------
(Updated Oct. 18, 2016, 5:46 p.m.)
Review request for hive and Ashutosh Chauhan.
Bugs: HIVE-14913
https://issues.apache.org/jira/browse/HIVE-14913
Repository: hive-git
Description
-------
Moved bunch of system tests to hive unit tests
Diffs (updated)
-----
itests/src/test/resources/testconfiguration.properties 97e310d
ql/src/test/queries/clientpositive/cte_1.q ca4132f
ql/src/test/queries/clientpositive/cte_2.q b49620a
ql/src/test/queries/clientpositive/current_date_timestamp.q 9bed885
ql/src/test/queries/clientpositive/insert1.q 4117b54
ql/src/test/queries/clientpositive/join_acid_non_acid.q 866b466
ql/src/test/queries/clientpositive/lvj_mapjoin.q b726e2a
ql/src/test/queries/clientpositive/orc_ppd_basic.q 43f2c85
ql/src/test/queries/clientpositive/schema_evol_orc_acid_part_update.q d971649
ql/src/test/queries/clientpositive/vectorization_0.q caa6a6a
ql/src/test/results/clientpositive/cte_1.q.out 6e7acf6
ql/src/test/results/clientpositive/cte_2.q.out 4b0bc71
ql/src/test/results/clientpositive/current_date_timestamp.q.out 9c26095
ql/src/test/results/clientpositive/insert1.q.out 7a2c429
ql/src/test/results/clientpositive/llap/cte_1.q.out 41ffdc7
ql/src/test/results/clientpositive/llap/cte_2.q.out 017bded
ql/src/test/results/clientpositive/llap/current_date_timestamp.q.out PRE-CREATION
ql/src/test/results/clientpositive/llap/insert1.q.out 4b30156
ql/src/test/results/clientpositive/llap/join_acid_non_acid.q.out 4905351
ql/src/test/results/clientpositive/llap/lvj_mapjoin.q.out dd4d024
ql/src/test/results/clientpositive/llap/orc_ppd_basic.q.out aa37ff3
ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_part_update.q.out ed698e1
ql/src/test/results/clientpositive/llap/vectorization_0.q.out faceb5c
ql/src/test/results/clientpositive/spark/alter_merge_orc.q.out b5a6d04
ql/src/test/results/clientpositive/spark/vectorization_0.q.out 22fe7cd
ql/src/test/results/clientpositive/vectorization_0.q.out ac33721
Diff: https://reviews.apache.org/r/52708/diff/
Testing
-------
Pre-commit testing
Thanks,
Vineet Garg
Re: Review Request 52708: HIVE-14913 Moved system tests to unit tests
Posted by Ashutosh Chauhan <ha...@apache.org>.
> On Oct. 14, 2016, 8:23 p.m., Ashutosh Chauhan wrote:
> > ql/src/test/queries/clientpositive/insert1.q, lines 49-51
> > <https://reviews.apache.org/r/52708/diff/1/?file=1530003#file1530003line49>
> >
> > insert overwrite local dir is best tested on cluster. So, doesnt make sense in ut.
>
> Vineet Garg wrote:
> So should we keep this in system tests ?
yes
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52708/#review152425
-----------------------------------------------------------
On Oct. 18, 2016, 5:46 p.m., Vineet Garg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52708/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2016, 5:46 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Bugs: HIVE-14913
> https://issues.apache.org/jira/browse/HIVE-14913
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Moved bunch of system tests to hive unit tests
>
>
> Diffs
> -----
>
> itests/src/test/resources/testconfiguration.properties 97e310d
> ql/src/test/queries/clientpositive/cte_1.q ca4132f
> ql/src/test/queries/clientpositive/cte_2.q b49620a
> ql/src/test/queries/clientpositive/current_date_timestamp.q 9bed885
> ql/src/test/queries/clientpositive/insert1.q 4117b54
> ql/src/test/queries/clientpositive/join_acid_non_acid.q 866b466
> ql/src/test/queries/clientpositive/lvj_mapjoin.q b726e2a
> ql/src/test/queries/clientpositive/orc_ppd_basic.q 43f2c85
> ql/src/test/queries/clientpositive/schema_evol_orc_acid_part_update.q d971649
> ql/src/test/queries/clientpositive/vectorization_0.q caa6a6a
> ql/src/test/results/clientpositive/cte_1.q.out 6e7acf6
> ql/src/test/results/clientpositive/cte_2.q.out 4b0bc71
> ql/src/test/results/clientpositive/current_date_timestamp.q.out 9c26095
> ql/src/test/results/clientpositive/insert1.q.out 7a2c429
> ql/src/test/results/clientpositive/llap/cte_1.q.out 41ffdc7
> ql/src/test/results/clientpositive/llap/cte_2.q.out 017bded
> ql/src/test/results/clientpositive/llap/current_date_timestamp.q.out PRE-CREATION
> ql/src/test/results/clientpositive/llap/insert1.q.out 4b30156
> ql/src/test/results/clientpositive/llap/join_acid_non_acid.q.out 4905351
> ql/src/test/results/clientpositive/llap/lvj_mapjoin.q.out dd4d024
> ql/src/test/results/clientpositive/llap/orc_ppd_basic.q.out aa37ff3
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_part_update.q.out ed698e1
> ql/src/test/results/clientpositive/llap/vectorization_0.q.out faceb5c
> ql/src/test/results/clientpositive/spark/alter_merge_orc.q.out b5a6d04
> ql/src/test/results/clientpositive/spark/vectorization_0.q.out 22fe7cd
> ql/src/test/results/clientpositive/vectorization_0.q.out ac33721
>
> Diff: https://reviews.apache.org/r/52708/diff/
>
>
> Testing
> -------
>
> Pre-commit testing
>
>
> Thanks,
>
> Vineet Garg
>
>
Re: Review Request 52708: HIVE-14913 Moved system tests to unit tests
Posted by Vineet Garg <vg...@hortonworks.com>.
> On Oct. 14, 2016, 8:23 p.m., Ashutosh Chauhan wrote:
> > ql/src/test/queries/clientpositive/insert1.q, lines 49-51
> > <https://reviews.apache.org/r/52708/diff/1/?file=1530003#file1530003line49>
> >
> > insert overwrite local dir is best tested on cluster. So, doesnt make sense in ut.
So should we keep this in system tests ?
- Vineet
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52708/#review152425
-----------------------------------------------------------
On Oct. 18, 2016, 5:46 p.m., Vineet Garg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52708/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2016, 5:46 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Bugs: HIVE-14913
> https://issues.apache.org/jira/browse/HIVE-14913
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Moved bunch of system tests to hive unit tests
>
>
> Diffs
> -----
>
> itests/src/test/resources/testconfiguration.properties 97e310d
> ql/src/test/queries/clientpositive/cte_1.q ca4132f
> ql/src/test/queries/clientpositive/cte_2.q b49620a
> ql/src/test/queries/clientpositive/current_date_timestamp.q 9bed885
> ql/src/test/queries/clientpositive/insert1.q 4117b54
> ql/src/test/queries/clientpositive/join_acid_non_acid.q 866b466
> ql/src/test/queries/clientpositive/lvj_mapjoin.q b726e2a
> ql/src/test/queries/clientpositive/orc_ppd_basic.q 43f2c85
> ql/src/test/queries/clientpositive/schema_evol_orc_acid_part_update.q d971649
> ql/src/test/queries/clientpositive/vectorization_0.q caa6a6a
> ql/src/test/results/clientpositive/cte_1.q.out 6e7acf6
> ql/src/test/results/clientpositive/cte_2.q.out 4b0bc71
> ql/src/test/results/clientpositive/current_date_timestamp.q.out 9c26095
> ql/src/test/results/clientpositive/insert1.q.out 7a2c429
> ql/src/test/results/clientpositive/llap/cte_1.q.out 41ffdc7
> ql/src/test/results/clientpositive/llap/cte_2.q.out 017bded
> ql/src/test/results/clientpositive/llap/current_date_timestamp.q.out PRE-CREATION
> ql/src/test/results/clientpositive/llap/insert1.q.out 4b30156
> ql/src/test/results/clientpositive/llap/join_acid_non_acid.q.out 4905351
> ql/src/test/results/clientpositive/llap/lvj_mapjoin.q.out dd4d024
> ql/src/test/results/clientpositive/llap/orc_ppd_basic.q.out aa37ff3
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_part_update.q.out ed698e1
> ql/src/test/results/clientpositive/llap/vectorization_0.q.out faceb5c
> ql/src/test/results/clientpositive/spark/alter_merge_orc.q.out b5a6d04
> ql/src/test/results/clientpositive/spark/vectorization_0.q.out 22fe7cd
> ql/src/test/results/clientpositive/vectorization_0.q.out ac33721
>
> Diff: https://reviews.apache.org/r/52708/diff/
>
>
> Testing
> -------
>
> Pre-commit testing
>
>
> Thanks,
>
> Vineet Garg
>
>
Re: Review Request 52708: HIVE-14913 Moved system tests to unit tests
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52708/#review152425
-----------------------------------------------------------
ql/src/test/queries/clientpositive/acid_globallimit.q (line 15)
<https://reviews.apache.org/r/52708/#comment221432>
covered in acid_table_stats.q
ql/src/test/queries/clientpositive/alter_merge_orc.q (line 44)
<https://reviews.apache.org/r/52708/#comment221799>
These tests looks like schema evolution, so better home for them will be in schema_evol* tests
ql/src/test/queries/clientpositive/alter_merge_orc.q (lines 79 - 99)
<https://reviews.apache.org/r/52708/#comment221800>
Lets just keep this one with json. We can get rid of tests above this. This covers that.
ql/src/test/queries/clientpositive/alter_merge_orc.q (line 139)
<https://reviews.apache.org/r/52708/#comment221801>
Lets keep just one count test for empty table. Avro one looks most suited.
ql/src/test/queries/clientpositive/alter_merge_orc.q (lines 187 - 189)
<https://reviews.apache.org/r/52708/#comment221803>
covered in optimize_nullscan.q
ql/src/test/queries/clientpositive/insert1.q (lines 49 - 51)
<https://reviews.apache.org/r/52708/#comment221806>
insert overwrite local dir is best tested on cluster. So, doesnt make sense in ut.
ql/src/test/queries/clientpositive/join_acid_non_acid.q (lines 45 - 47)
<https://reviews.apache.org/r/52708/#comment221807>
Can we use orc_update table here for union all? Will be faster.
ql/src/test/queries/clientpositive/orc_ppd_basic.q (lines 203 - 212)
<https://reviews.apache.org/r/52708/#comment221825>
No need to run with config=false. Thats covered elsewhere.
ql/src/test/queries/clientpositive/orc_ppd_basic.q (lines 232 - 235)
<https://reviews.apache.org/r/52708/#comment221826>
No need for config=false
ql/src/test/queries/clientpositive/windowing_gby.q (lines 10 - 17)
<https://reviews.apache.org/r/52708/#comment221431>
These tests are already covered in windowing* tests.
- Ashutosh Chauhan
On Oct. 10, 2016, 9:48 p.m., Vineet Garg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52708/
> -----------------------------------------------------------
>
> (Updated Oct. 10, 2016, 9:48 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Bugs: HIVE-14913
> https://issues.apache.org/jira/browse/HIVE-14913
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Moved bunch of system tests to hive unit tests
>
>
> Diffs
> -----
>
> itests/src/test/resources/testconfiguration.properties fbba0cd
> ql/src/test/queries/clientpositive/acid_globallimit.q 7fa4c07
> ql/src/test/queries/clientpositive/alter_merge_orc.q aac98a8
> ql/src/test/queries/clientpositive/cte_1.q ca4132f
> ql/src/test/queries/clientpositive/cte_2.q b49620a
> ql/src/test/queries/clientpositive/current_date_timestamp.q 9bed885
> ql/src/test/queries/clientpositive/insert1.q 4117b54
> ql/src/test/queries/clientpositive/join_acid_non_acid.q 866b466
> ql/src/test/queries/clientpositive/lvj_mapjoin.q b726e2a
> ql/src/test/queries/clientpositive/orc_ppd_basic.q 43f2c85
> ql/src/test/queries/clientpositive/vectorization_0.q caa6a6a
> ql/src/test/queries/clientpositive/windowing_gby.q e1a536b
> ql/src/test/results/clientpositive/acid_globallimit.q.out fe738a6
> ql/src/test/results/clientpositive/alter_merge_orc.q.out b5a6d04
> ql/src/test/results/clientpositive/cte_1.q.out 6e7acf6
> ql/src/test/results/clientpositive/cte_2.q.out 4b0bc71
> ql/src/test/results/clientpositive/current_date_timestamp.q.out 9c26095
> ql/src/test/results/clientpositive/insert1.q.out 7a2c429
> ql/src/test/results/clientpositive/llap/acid_globallimit.q.out 6f0e46e
> ql/src/test/results/clientpositive/llap/alter_merge_orc.q.out b5a6d04
> ql/src/test/results/clientpositive/llap/cte_1.q.out 41ffdc7
> ql/src/test/results/clientpositive/llap/cte_2.q.out 017bded
> ql/src/test/results/clientpositive/llap/current_date_timestamp.q.out PRE-CREATION
> ql/src/test/results/clientpositive/llap/insert1.q.out 4b30156
> ql/src/test/results/clientpositive/llap/join_acid_non_acid.q.out 4905351
> ql/src/test/results/clientpositive/llap/lvj_mapjoin.q.out dd4d024
> ql/src/test/results/clientpositive/llap/orc_ppd_basic.q.out aa37ff3
> ql/src/test/results/clientpositive/llap/vectorization_0.q.out faceb5c
> ql/src/test/results/clientpositive/llap/windowing_gby.q.out a31a4b2
> ql/src/test/results/clientpositive/spark/alter_merge_orc.q.out b5a6d04
> ql/src/test/results/clientpositive/spark/vectorization_0.q.out 22fe7cd
> ql/src/test/results/clientpositive/vectorization_0.q.out ac33721
>
> Diff: https://reviews.apache.org/r/52708/diff/
>
>
> Testing
> -------
>
> Pre-commit testing
>
>
> Thanks,
>
> Vineet Garg
>
>