You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tomcat.apache.org by "Craig R. McClanahan" <Cr...@eng.sun.com> on 2000/07/25 18:10:43 UTC

Re: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/service/http HttpRequestAdapter.java

nacho@locus.apache.org wrote:

> nacho       00/07/25 05:44:06
>
>   Modified:    src/share/org/apache/tomcat/service/http
>                         HttpRequestAdapter.java
>   Log:
>   This is a bad place to make a Decode(querystring) , ithe querystring
>   may be decoded by the servlet that uses it.
>

This is undoubtedly true (isn't hindsight wonderful) when the query string is not used for parameters, but what happens when Tomcat tries to parse it
in response to a request.getParameter() type call?  I think we might still need to add an explicit decode at that point, but haven't thoroughly
examined the issue yet.

Craig