You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/01/24 00:03:26 UTC

[GitHub] piyushghai commented on a change in pull request #12690: [MXNET-1000] get Ndarray real value and form it from a NDArray

piyushghai commented on a change in pull request #12690: [MXNET-1000] get Ndarray real value and form it from a NDArray
URL: https://github.com/apache/incubator-mxnet/pull/12690#discussion_r250421577
 
 

 ##########
 File path: scala-package/core/src/main/scala/org/apache/mxnet/MX_PRIMITIVES.scala
 ##########
 @@ -82,4 +82,10 @@ object MX_PRIMITIVES {
 
   implicit def MX_DoubleToDouble(d: MX_Double) : Double = d.data
 
+  def isValidType(num : Any) : Boolean = {
 
 Review comment:
   Can this be renamed to ```isValidMxPrimitiveType```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services