You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by "RocMarshal (via GitHub)" <gi...@apache.org> on 2023/02/20 13:32:05 UTC
[GitHub] [incubator-streampark] RocMarshal opened a new pull request, #2347: [Bug] Fix can't update yarnQueue when update application.
RocMarshal opened a new pull request, #2347:
URL: https://github.com/apache/incubator-streampark/pull/2347
<!--
Thank you for contributing to StreamPark! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
## Contribution Checklist
- If this is your first time, please read our contributor guidelines: [Submit Code](https://streampark.apache.org/community/submit_guide/submit_code).
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-streampark/issues).
- Name the pull request in the form "[Feature] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- If the PR is unfinished, add `[WIP]` in your PR title, e.g., `[WIP][Feature] Title of the pull request`.
-->
## What changes were proposed in this pull request
The logic when update yarn queue of app
<!--(For example: This pull request proposed to add checkstyle plugin).-->
## Brief change log
change the logic when update yarn queue of app
## Verifying this change
- *Manually verified the change by testing locally.*
## Does this pull request potentially affect one of the following parts
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys merged pull request #2347: [Bug] Fix can't update yarnQueue when update application.
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys merged PR #2347:
URL: https://github.com/apache/incubator-streampark/pull/2347
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] RocMarshal commented on a diff in pull request #2347: [Bug] Fix can't update yarnQueue when update application.
Posted by "RocMarshal (via GitHub)" <gi...@apache.org>.
RocMarshal commented on code in PR #2347:
URL: https://github.com/apache/incubator-streampark/pull/2347#discussion_r1111968019
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/entity/Application.java:
##########
@@ -595,6 +598,9 @@ public void doSetHotParams() {
@SneakyThrows
public void updateHotParams(Application appParam) {
+ if (appParam != this) {
Review Comment:
to deal the case when set the null or empty queue.
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/entity/Application.java:
##########
@@ -133,7 +133,10 @@ public class Application implements Serializable {
private String module;
private String options;
+
+ @TableField(updateStrategy = FieldStrategy.IGNORED)
Review Comment:
for `null` value on `hotParams`
##########
streampark-console/streampark-console-webapp/src/views/flink/app/hooks/useCreateAndEditSchema.ts:
##########
@@ -468,7 +468,7 @@ export const useCreateAndEditSchema = (
label: t('flink.app.yarnQueue'),
component: 'Input',
ifShow: ({ values }) => values.executionMode == ExecModeEnum.YARN_APPLICATION || values.executionMode == ExecModeEnum.YARN_PER_JOB,
- render: renderYarnQueue
+ render: (renderCallbackParams) => renderYarnQueue(renderCallbackParams)
Review Comment:
The bug from Issue-2299
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org