You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/02/09 00:56:55 UTC
[GitHub] justinborromeo opened a new pull request #7043: 2528 Replace
Incremental Index Global Flags with Getters
justinborromeo opened a new pull request #7043: 2528 Replace Incremental Index Global Flags with Getters
URL: https://github.com/apache/incubator-druid/pull/7043
Some parameters in the addToFacts function of IncrementalIndex are replaced with getters for their corresponding class member variables. This change addresses #2528 which is based on the discussion in #2519.
The parameters removed were:
Boolean: deserializeComplexMetrics
Boolean: reportParseExceptions
AtomicInteger: numEntries
AggregatorFactory[]: metrics
AtomicLong[]: sizeInBytes/bytesInMemory
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org