You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@spamassassin.apache.org by jm...@apache.org on 2007/04/19 15:58:38 UTC

svn commit: r530418 - /spamassassin/trunk/lib/Mail/SpamAssassin/Util.pm

Author: jm
Date: Thu Apr 19 06:58:37 2007
New Revision: 530418

URL: http://svn.apache.org/viewvc?view=rev&rev=530418
Log:
fix Win32 bug, whereby the path to the perl interpreter was winding up in headers of messages processed using 'report_safe 1', due to broken code which added that path as a means of tainting a variable, then failed to remove it properly again

Modified:
    spamassassin/trunk/lib/Mail/SpamAssassin/Util.pm

Modified: spamassassin/trunk/lib/Mail/SpamAssassin/Util.pm
URL: http://svn.apache.org/viewvc/spamassassin/trunk/lib/Mail/SpamAssassin/Util.pm?view=diff&rev=530418&r1=530417&r2=530418
==============================================================================
--- spamassassin/trunk/lib/Mail/SpamAssassin/Util.pm (original)
+++ spamassassin/trunk/lib/Mail/SpamAssassin/Util.pm Thu Apr 19 06:58:37 2007
@@ -290,7 +290,8 @@
 
   # $^X is apparently "always tainted".  We can use this to render
   # a string tainted as follows:
-  $v .= $^X; $v =~ s/${^X}$//;
+  my $tainter = substr ($^X."_", 0, 1);     # get 1 tainted char
+  $v .= $tainter; chop $v;      # then add and remove it
 
   return $v;
 }