You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@bigtop.apache.org by GitBox <gi...@apache.org> on 2021/03/17 02:16:40 UTC

[GitHub] [bigtop] JunHe77 commented on a change in pull request #759: BIGTOP-3526: Remove phantomjs dependency from yarn-ui

JunHe77 commented on a change in pull request #759:
URL: https://github.com/apache/bigtop/pull/759#discussion_r595664365



##########
File path: bigtop-packages/src/common/hadoop/do-component-build
##########
@@ -125,6 +125,8 @@ MAVEN_OPTS+="-DskipTests -DskipTest -DskipITs "
 . $(dirname ${0})/maven_deploy.sh
 
 # Build artifacts
+# remove phantomjs dependency
+sed -i '/^phantomjs-prebuilt/,+12d;N;/phantomjs/!P;D' hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/yarn.lock

Review comment:
       That should be a better way. I'll upload a new patchset. Thanks, @iwasakims 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org