You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2011/09/13 07:29:09 UTC
[jira] [Created] (HBASE-4382) Region encoded name is hash of
tablename + start key + regionid (timestamp); should include end key when
hashing.
Region encoded name is hash of tablename + start key + regionid (timestamp); should include end key when hashing.
-----------------------------------------------------------------------------------------------------------------
Key: HBASE-4382
URL: https://issues.apache.org/jira/browse/HBASE-4382
Project: HBase
Issue Type: Improvement
Reporter: stack
Seems odd that region encoded name is same for regions if made in same second with same start key tough their end keys are different. It can happen in unit test. Should mix in the end key when coming up w/ the region name encoded name.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4382) Region encoded name is hash of
tablename + start key + regionid (timestamp); should include end key when
hashing.
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168874#comment-13168874 ]
jiraposter@reviews.apache.org commented on HBASE-4382:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3190/
-----------------------------------------------------------
(Updated 2011-12-13 23:36:43.094808)
Review request for hbase.
Summary
-------
PART 3 of hbase-4616
Seems odd that region encoded name is same for regions if made in same second with same start key tough their end keys are different. It can happen in unit test. Should mix in the end key when coming up w/ the region name encoded name.
This addresses bug hbase-4382.
https://issues.apache.org/jira/browse/hbase-4382
Diffs (updated)
-----
src/main/java/org/apache/hadoop/hbase/HRegionInfo.java 74cb821
Diff: https://reviews.apache.org/r/3190/diff
Testing
-------
Thanks,
Alex
> Region encoded name is hash of tablename + start key + regionid (timestamp); should include end key when hashing.
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4382
> URL: https://issues.apache.org/jira/browse/HBASE-4382
> Project: HBase
> Issue Type: Sub-task
> Reporter: stack
> Assignee: Alex Newman
> Labels: noob
> Attachments: 0003-Verify-start-and-end-key-are-contained-in-the-encode.patch
>
>
> Seems odd that region encoded name is same for regions if made in same second with same start key tough their end keys are different. It can happen in unit test. Should mix in the end key when coming up w/ the region name encoded name.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4382) Region encoded name is hash of
tablename + start key + regionid (timestamp); should include end key when
hashing.
Posted by "Alex Newman (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Newman updated HBASE-4382:
-------------------------------
Attachment: 0001-HBASE-2600.-Change-how-we-do-meta-tables-from-tablen.patch
> Region encoded name is hash of tablename + start key + regionid (timestamp); should include end key when hashing.
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4382
> URL: https://issues.apache.org/jira/browse/HBASE-4382
> Project: HBase
> Issue Type: Sub-task
> Reporter: stack
> Assignee: Alex Newman
> Labels: noob
> Attachments: 0003-Verify-start-and-end-key-are-contained-in-the-encode.patch
>
>
> Seems odd that region encoded name is same for regions if made in same second with same start key tough their end keys are different. It can happen in unit test. Should mix in the end key when coming up w/ the region name encoded name.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4382) Region encoded name is hash of
tablename + start key + regionid (timestamp); should include end key when
hashing.
Posted by "Alex Newman (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127987#comment-13127987 ]
Alex Newman commented on HBASE-4382:
------------------------------------
Wont this change the format of the data in meta. Are we ok with that?
> Region encoded name is hash of tablename + start key + regionid (timestamp); should include end key when hashing.
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4382
> URL: https://issues.apache.org/jira/browse/HBASE-4382
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: Alex Newman
> Labels: noob
>
> Seems odd that region encoded name is same for regions if made in same second with same start key tough their end keys are different. It can happen in unit test. Should mix in the end key when coming up w/ the region name encoded name.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4382) Region encoded name is hash of
tablename + start key + regionid (timestamp); should include end key when
hashing.
Posted by "Alex Newman (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Newman updated HBASE-4382:
-------------------------------
Status: Patch Available (was: Open)
> Region encoded name is hash of tablename + start key + regionid (timestamp); should include end key when hashing.
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4382
> URL: https://issues.apache.org/jira/browse/HBASE-4382
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: Alex Newman
> Labels: noob
> Attachments: 0001-HBASE-4382.-Region-encoded-name-is-hash-of-tablename.patch
>
>
> Seems odd that region encoded name is same for regions if made in same second with same start key tough their end keys are different. It can happen in unit test. Should mix in the end key when coming up w/ the region name encoded name.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4382) Region encoded name is hash of
tablename + start key + regionid (timestamp); should include end key when
hashing.
Posted by "Alex Newman (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126968#comment-13126968 ]
Alex Newman commented on HBASE-4382:
------------------------------------
*nod
> Region encoded name is hash of tablename + start key + regionid (timestamp); should include end key when hashing.
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4382
> URL: https://issues.apache.org/jira/browse/HBASE-4382
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: Alex Newman
> Labels: noob
>
> Seems odd that region encoded name is same for regions if made in same second with same start key tough their end keys are different. It can happen in unit test. Should mix in the end key when coming up w/ the region name encoded name.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4382) Region encoded name is hash of
tablename + start key + regionid (timestamp); should include end key when
hashing.
Posted by "Alex Newman (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127659#comment-13127659 ]
Alex Newman commented on HBASE-4382:
------------------------------------
Sounds good I'll double check all of the javadoc and resubmit. I'm more worried about the above errors though.
> Region encoded name is hash of tablename + start key + regionid (timestamp); should include end key when hashing.
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4382
> URL: https://issues.apache.org/jira/browse/HBASE-4382
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: Alex Newman
> Labels: noob
> Attachments: 0001-HBASE-4382.-Region-encoded-name-is-hash-of-tablename.patch
>
>
> Seems odd that region encoded name is same for regions if made in same second with same start key tough their end keys are different. It can happen in unit test. Should mix in the end key when coming up w/ the region name encoded name.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4382) Region encoded name is hash of
tablename + start key + regionid (timestamp); should include end key when
hashing.
Posted by "Alex Newman (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Newman updated HBASE-4382:
-------------------------------
Attachment: 0003-Verify-start-and-end-key-are-contained-in-the-encode.patch
> Region encoded name is hash of tablename + start key + regionid (timestamp); should include end key when hashing.
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4382
> URL: https://issues.apache.org/jira/browse/HBASE-4382
> Project: HBase
> Issue Type: Sub-task
> Reporter: stack
> Assignee: Alex Newman
> Labels: noob
> Attachments: 0003-Verify-start-and-end-key-are-contained-in-the-encode.patch
>
>
> Seems odd that region encoded name is same for regions if made in same second with same start key tough their end keys are different. It can happen in unit test. Should mix in the end key when coming up w/ the region name encoded name.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4382) Region encoded name is hash of
tablename + start key + regionid (timestamp); should include end key when
hashing.
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168723#comment-13168723 ]
jiraposter@reviews.apache.org commented on HBASE-4382:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3190/
-----------------------------------------------------------
Review request for hbase.
Summary
-------
PART 3 of hbase-4616
Seems odd that region encoded name is same for regions if made in same second with same start key tough their end keys are different. It can happen in unit test. Should mix in the end key when coming up w/ the region name encoded name.
This addresses bug hbase-4382.
https://issues.apache.org/jira/browse/hbase-4382
Diffs
-----
src/main/java/org/apache/hadoop/hbase/HRegionInfo.java 74cb821
Diff: https://reviews.apache.org/r/3190/diff
Testing
-------
Thanks,
Alex
> Region encoded name is hash of tablename + start key + regionid (timestamp); should include end key when hashing.
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4382
> URL: https://issues.apache.org/jira/browse/HBASE-4382
> Project: HBase
> Issue Type: Sub-task
> Reporter: stack
> Assignee: Alex Newman
> Labels: noob
> Attachments: 0003-Verify-start-and-end-key-are-contained-in-the-encode.patch
>
>
> Seems odd that region encoded name is same for regions if made in same second with same start key tough their end keys are different. It can happen in unit test. Should mix in the end key when coming up w/ the region name encoded name.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4382) Region encoded name is hash of
tablename + start key + regionid (timestamp); should include end key when
hashing.
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159607#comment-13159607 ]
jiraposter@reviews.apache.org commented on HBASE-4382:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2963/
-----------------------------------------------------------
Review request for hbase.
Summary
-------
Seems odd that region encoded name is same for regions if made in same second with same start key tough their end keys are different. It can happen in unit test. Should mix in the end key when coming up w/ the region name encoded name.
This addresses bug hbase-4382.
https://issues.apache.org/jira/browse/hbase-4382
Diffs
-----
src/main/java/org/apache/hadoop/hbase/HConstants.java d22f50a
src/main/java/org/apache/hadoop/hbase/HRegionInfo.java 0c1fa3f
src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java 1c49dc5
src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java e5e60a8
src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java aa8512b
src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 6af1f82
src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java 4135e55
src/main/java/org/apache/hadoop/hbase/client/MetaSearchRow.java PRE-CREATION
src/main/java/org/apache/hadoop/hbase/regionserver/SplitTransaction.java 08b7de3
src/main/java/org/apache/hadoop/hbase/rest/RegionsResource.java bf85bc1
src/main/java/org/apache/hadoop/hbase/rest/model/TableRegionModel.java 67e7a04
src/main/resources/hbase-default.xml 7059c60
src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java 66d808f
src/test/java/org/apache/hadoop/hbase/TestKeyValue.java 7af4db4
src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java 940d726
src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java b579b29
src/test/java/org/apache/hadoop/hbase/regionserver/TestGetClosestAtOrBefore.java 49bfc5a
src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java 477e772
src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java 24903f3
src/test/java/org/apache/hadoop/hbase/rest/TestStatusResource.java 4a8bb69
src/test/java/org/apache/hadoop/hbase/rest/model/TestTableRegionModel.java 60e0e41
src/test/ruby/hbase/admin_test.rb 0c2672b
Diff: https://reviews.apache.org/r/2963/diff
Testing
-------
Thanks,
Alex
> Region encoded name is hash of tablename + start key + regionid (timestamp); should include end key when hashing.
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4382
> URL: https://issues.apache.org/jira/browse/HBASE-4382
> Project: HBase
> Issue Type: Sub-task
> Reporter: stack
> Assignee: Alex Newman
> Labels: noob
>
> Seems odd that region encoded name is same for regions if made in same second with same start key tough their end keys are different. It can happen in unit test. Should mix in the end key when coming up w/ the region name encoded name.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4382) Region encoded name is hash of
tablename + start key + regionid (timestamp); should include end key when
hashing.
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159609#comment-13159609 ]
jiraposter@reviews.apache.org commented on HBASE-4382:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2963/#review3566
-----------------------------------------------------------
src/main/java/org/apache/hadoop/hbase/HRegionInfo.java
<https://reviews.apache.org/r/2963/#comment7984>
I promise not to commit this.
- Alex
On 2011-11-29 22:52:32, Alex Newman wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2963/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-29 22:52:32)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Seems odd that region encoded name is same for regions if made in same second with same start key tough their end keys are different. It can happen in unit test. Should mix in the end key when coming up w/ the region name encoded name.
bq.
bq.
bq. This addresses bug hbase-4382.
bq. https://issues.apache.org/jira/browse/hbase-4382
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/HConstants.java d22f50a
bq. src/main/java/org/apache/hadoop/hbase/HRegionInfo.java 0c1fa3f
bq. src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java 1c49dc5
bq. src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java e5e60a8
bq. src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java aa8512b
bq. src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 6af1f82
bq. src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java 4135e55
bq. src/main/java/org/apache/hadoop/hbase/client/MetaSearchRow.java PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/regionserver/SplitTransaction.java 08b7de3
bq. src/main/java/org/apache/hadoop/hbase/rest/RegionsResource.java bf85bc1
bq. src/main/java/org/apache/hadoop/hbase/rest/model/TableRegionModel.java 67e7a04
bq. src/main/resources/hbase-default.xml 7059c60
bq. src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java 66d808f
bq. src/test/java/org/apache/hadoop/hbase/TestKeyValue.java 7af4db4
bq. src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java 940d726
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java b579b29
bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestGetClosestAtOrBefore.java 49bfc5a
bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java 477e772
bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java 24903f3
bq. src/test/java/org/apache/hadoop/hbase/rest/TestStatusResource.java 4a8bb69
bq. src/test/java/org/apache/hadoop/hbase/rest/model/TestTableRegionModel.java 60e0e41
bq. src/test/ruby/hbase/admin_test.rb 0c2672b
bq.
bq. Diff: https://reviews.apache.org/r/2963/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Alex
bq.
bq.
> Region encoded name is hash of tablename + start key + regionid (timestamp); should include end key when hashing.
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4382
> URL: https://issues.apache.org/jira/browse/HBASE-4382
> Project: HBase
> Issue Type: Sub-task
> Reporter: stack
> Assignee: Alex Newman
> Labels: noob
>
> Seems odd that region encoded name is same for regions if made in same second with same start key tough their end keys are different. It can happen in unit test. Should mix in the end key when coming up w/ the region name encoded name.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4382) Region encoded name is hash of
tablename + start key + regionid (timestamp); should include end key when
hashing.
Posted by "Alex Newman (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127640#comment-13127640 ]
Alex Newman commented on HBASE-4382:
------------------------------------
So I am slightly concerned about this patch: it looks like
>>> org.apache.hadoop.hbase.avro.TestAvroServer.testTableAdminAndMetadata 5.444 2
>>> org.apache.hadoop.hbase.avro.TestAvroServer.testFamilyAdminAndMetadata 0.035 2
>>> org.apache.hadoop.hbase.avro.TestAvroServer.testDML
Failed in my hudson. But when I ran them manually they passed. I'm going to assume they are just flakey. If so is there a jira for that?
Furthermore, no real tests broke when I changed this format. Should I add a unit test somewhere to verify the format or am I just being paranoid?
> Region encoded name is hash of tablename + start key + regionid (timestamp); should include end key when hashing.
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4382
> URL: https://issues.apache.org/jira/browse/HBASE-4382
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: Alex Newman
> Labels: noob
> Attachments: 0001-HBASE-4382.-Region-encoded-name-is-hash-of-tablename.patch
>
>
> Seems odd that region encoded name is same for regions if made in same second with same start key tough their end keys are different. It can happen in unit test. Should mix in the end key when coming up w/ the region name encoded name.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4382) Region encoded name is hash of
tablename + start key + regionid (timestamp); should include end key when
hashing.
Posted by "Alex Newman (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127672#comment-13127672 ]
Alex Newman commented on HBASE-4382:
------------------------------------
Ok it looks like I might have broke those tests. I'm going to try to track down what they do.
> Region encoded name is hash of tablename + start key + regionid (timestamp); should include end key when hashing.
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4382
> URL: https://issues.apache.org/jira/browse/HBASE-4382
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: Alex Newman
> Labels: noob
> Attachments: 0001-HBASE-4382.-Region-encoded-name-is-hash-of-tablename.patch
>
>
> Seems odd that region encoded name is same for regions if made in same second with same start key tough their end keys are different. It can happen in unit test. Should mix in the end key when coming up w/ the region name encoded name.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4382) Region encoded name is hash of
tablename + start key + regionid (timestamp); should include end key when
hashing.
Posted by "Alex Newman (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127684#comment-13127684 ]
Alex Newman commented on HBASE-4382:
------------------------------------
Ok I see that I missed a lot of touch points. I'm going to cancel the patch add the needed code and repost in probably about 3 hours.
> Region encoded name is hash of tablename + start key + regionid (timestamp); should include end key when hashing.
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4382
> URL: https://issues.apache.org/jira/browse/HBASE-4382
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: Alex Newman
> Labels: noob
>
> Seems odd that region encoded name is same for regions if made in same second with same start key tough their end keys are different. It can happen in unit test. Should mix in the end key when coming up w/ the region name encoded name.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-4382) Region encoded name is hash of
tablename + start key + regionid (timestamp); should include end key when
hashing.
Posted by "Alex Newman (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Newman reassigned HBASE-4382:
----------------------------------
Assignee: Alex Newman
> Region encoded name is hash of tablename + start key + regionid (timestamp); should include end key when hashing.
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4382
> URL: https://issues.apache.org/jira/browse/HBASE-4382
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: Alex Newman
> Labels: noob
>
> Seems odd that region encoded name is same for regions if made in same second with same start key tough their end keys are different. It can happen in unit test. Should mix in the end key when coming up w/ the region name encoded name.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4382) Region encoded name is hash of
tablename + start key + regionid (timestamp); should include end key when
hashing.
Posted by "Alex Newman (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Newman updated HBASE-4382:
-------------------------------
Attachment: (was: 0001-HBASE-4382.-Region-encoded-name-is-hash-of-tablename.patch)
> Region encoded name is hash of tablename + start key + regionid (timestamp); should include end key when hashing.
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4382
> URL: https://issues.apache.org/jira/browse/HBASE-4382
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: Alex Newman
> Labels: noob
>
> Seems odd that region encoded name is same for regions if made in same second with same start key tough their end keys are different. It can happen in unit test. Should mix in the end key when coming up w/ the region name encoded name.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4382) Region encoded name is hash of
tablename + start key + regionid (timestamp); should include end key when
hashing.
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159876#comment-13159876 ]
jiraposter@reviews.apache.org commented on HBASE-4382:
------------------------------------------------------
bq. On 2011-11-30 06:52:58, Prakash Khemani wrote:
bq. > Is this change backward compatible?
bq. >
bq. > I didn't quite get the motivation for the change. If there are tests that create overlapping regions (i.e. regions w/ same start key) then aren't those tests at fault?
One side note, this review was discarded as I posted all of this stuff in a confusing manner on my first try. In the future, it might more sense to comment on the jira.
On the first question, no it isn't and we will need a migration script as a part of 4616.
On the second, I agree about the tests part, if that's what was meant in the jira. On the other hand, wouldn't it be nice if we could uniquely identify meta/root key entries after a split? It just feels right to me. The nice part about it being a hash is that this doesn't create storage overhead. I could check for performance issues if that's what your worried about.
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2963/#review3575
-----------------------------------------------------------
On 2011-11-29 22:52:32, Alex Newman wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2963/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-29 22:52:32)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Seems odd that region encoded name is same for regions if made in same second with same start key tough their end keys are different. It can happen in unit test. Should mix in the end key when coming up w/ the region name encoded name.
bq.
bq.
bq. This addresses bug hbase-4382.
bq. https://issues.apache.org/jira/browse/hbase-4382
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/HConstants.java d22f50a
bq. src/main/java/org/apache/hadoop/hbase/HRegionInfo.java 0c1fa3f
bq. src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java 1c49dc5
bq. src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java e5e60a8
bq. src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java aa8512b
bq. src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 6af1f82
bq. src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java 4135e55
bq. src/main/java/org/apache/hadoop/hbase/client/MetaSearchRow.java PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/regionserver/SplitTransaction.java 08b7de3
bq. src/main/java/org/apache/hadoop/hbase/rest/RegionsResource.java bf85bc1
bq. src/main/java/org/apache/hadoop/hbase/rest/model/TableRegionModel.java 67e7a04
bq. src/main/resources/hbase-default.xml 7059c60
bq. src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java 66d808f
bq. src/test/java/org/apache/hadoop/hbase/TestKeyValue.java 7af4db4
bq. src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java 940d726
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java b579b29
bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestGetClosestAtOrBefore.java 49bfc5a
bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java 477e772
bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java 24903f3
bq. src/test/java/org/apache/hadoop/hbase/rest/TestStatusResource.java 4a8bb69
bq. src/test/java/org/apache/hadoop/hbase/rest/model/TestTableRegionModel.java 60e0e41
bq. src/test/ruby/hbase/admin_test.rb 0c2672b
bq.
bq. Diff: https://reviews.apache.org/r/2963/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Alex
bq.
bq.
> Region encoded name is hash of tablename + start key + regionid (timestamp); should include end key when hashing.
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4382
> URL: https://issues.apache.org/jira/browse/HBASE-4382
> Project: HBase
> Issue Type: Sub-task
> Reporter: stack
> Assignee: Alex Newman
> Labels: noob
>
> Seems odd that region encoded name is same for regions if made in same second with same start key tough their end keys are different. It can happen in unit test. Should mix in the end key when coming up w/ the region name encoded name.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4382) Region encoded name is hash of
tablename + start key + regionid (timestamp); should include end key when
hashing.
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168728#comment-13168728 ]
jiraposter@reviews.apache.org commented on HBASE-4382:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3190/
-----------------------------------------------------------
(Updated 2011-12-13 21:13:05.977763)
Review request for hbase.
Summary
-------
PART 3 of hbase-4616
Seems odd that region encoded name is same for regions if made in same second with same start key tough their end keys are different. It can happen in unit test. Should mix in the end key when coming up w/ the region name encoded name.
This addresses bug hbase-4382.
https://issues.apache.org/jira/browse/hbase-4382
Diffs (updated)
-----
src/main/java/org/apache/hadoop/hbase/HRegionInfo.java 74cb821
Diff: https://reviews.apache.org/r/3190/diff
Testing
-------
Thanks,
Alex
> Region encoded name is hash of tablename + start key + regionid (timestamp); should include end key when hashing.
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4382
> URL: https://issues.apache.org/jira/browse/HBASE-4382
> Project: HBase
> Issue Type: Sub-task
> Reporter: stack
> Assignee: Alex Newman
> Labels: noob
> Attachments: 0003-Verify-start-and-end-key-are-contained-in-the-encode.patch
>
>
> Seems odd that region encoded name is same for regions if made in same second with same start key tough their end keys are different. It can happen in unit test. Should mix in the end key when coming up w/ the region name encoded name.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4382) Region encoded name is hash of
tablename + start key + regionid (timestamp); should include end key when
hashing.
Posted by "Alex Newman (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Newman updated HBASE-4382:
-------------------------------
Attachment: 0001-HBASE-4382.-Region-encoded-name-is-hash-of-tablename.patch
> Region encoded name is hash of tablename + start key + regionid (timestamp); should include end key when hashing.
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4382
> URL: https://issues.apache.org/jira/browse/HBASE-4382
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: Alex Newman
> Labels: noob
> Attachments: 0001-HBASE-4382.-Region-encoded-name-is-hash-of-tablename.patch
>
>
> Seems odd that region encoded name is same for regions if made in same second with same start key tough their end keys are different. It can happen in unit test. Should mix in the end key when coming up w/ the region name encoded name.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4382) Region encoded name is hash of
tablename + start key + regionid (timestamp); should include end key when
hashing.
Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127991#comment-13127991 ]
Ted Yu commented on HBASE-4382:
-------------------------------
I had the same question when I reviewed Alex's patch.
If we do change the format of data in .META., the change should be bundled with HBASE-2600.
> Region encoded name is hash of tablename + start key + regionid (timestamp); should include end key when hashing.
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4382
> URL: https://issues.apache.org/jira/browse/HBASE-4382
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: Alex Newman
> Labels: noob
>
> Seems odd that region encoded name is same for regions if made in same second with same start key tough their end keys are different. It can happen in unit test. Should mix in the end key when coming up w/ the region name encoded name.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4382) Region encoded name is hash of
tablename + start key + regionid (timestamp); should include end key when
hashing.
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159866#comment-13159866 ]
jiraposter@reviews.apache.org commented on HBASE-4382:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2963/#review3575
-----------------------------------------------------------
Is this change backward compatible?
I didn't quite get the motivation for the change. If there are tests that create overlapping regions (i.e. regions w/ same start key) then aren't those tests at fault?
- Prakash
On 2011-11-29 22:52:32, Alex Newman wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2963/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-29 22:52:32)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Seems odd that region encoded name is same for regions if made in same second with same start key tough their end keys are different. It can happen in unit test. Should mix in the end key when coming up w/ the region name encoded name.
bq.
bq.
bq. This addresses bug hbase-4382.
bq. https://issues.apache.org/jira/browse/hbase-4382
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/HConstants.java d22f50a
bq. src/main/java/org/apache/hadoop/hbase/HRegionInfo.java 0c1fa3f
bq. src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java 1c49dc5
bq. src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java e5e60a8
bq. src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java aa8512b
bq. src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 6af1f82
bq. src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java 4135e55
bq. src/main/java/org/apache/hadoop/hbase/client/MetaSearchRow.java PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/regionserver/SplitTransaction.java 08b7de3
bq. src/main/java/org/apache/hadoop/hbase/rest/RegionsResource.java bf85bc1
bq. src/main/java/org/apache/hadoop/hbase/rest/model/TableRegionModel.java 67e7a04
bq. src/main/resources/hbase-default.xml 7059c60
bq. src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java 66d808f
bq. src/test/java/org/apache/hadoop/hbase/TestKeyValue.java 7af4db4
bq. src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java 940d726
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java b579b29
bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestGetClosestAtOrBefore.java 49bfc5a
bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java 477e772
bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java 24903f3
bq. src/test/java/org/apache/hadoop/hbase/rest/TestStatusResource.java 4a8bb69
bq. src/test/java/org/apache/hadoop/hbase/rest/model/TestTableRegionModel.java 60e0e41
bq. src/test/ruby/hbase/admin_test.rb 0c2672b
bq.
bq. Diff: https://reviews.apache.org/r/2963/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Alex
bq.
bq.
> Region encoded name is hash of tablename + start key + regionid (timestamp); should include end key when hashing.
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4382
> URL: https://issues.apache.org/jira/browse/HBASE-4382
> Project: HBase
> Issue Type: Sub-task
> Reporter: stack
> Assignee: Alex Newman
> Labels: noob
>
> Seems odd that region encoded name is same for regions if made in same second with same start key tough their end keys are different. It can happen in unit test. Should mix in the end key when coming up w/ the region name encoded name.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4382) Region encoded name is hash of
tablename + start key + regionid (timestamp); should include end key when
hashing.
Posted by "Alex Newman (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168730#comment-13168730 ]
Alex Newman commented on HBASE-4382:
------------------------------------
I updated the review for this change, although this should still be considered a talking point we still need to figure out migrations and a couple of tests. I am just curious if the approach makes sense.
> Region encoded name is hash of tablename + start key + regionid (timestamp); should include end key when hashing.
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4382
> URL: https://issues.apache.org/jira/browse/HBASE-4382
> Project: HBase
> Issue Type: Sub-task
> Reporter: stack
> Assignee: Alex Newman
> Labels: noob
> Attachments: 0003-Verify-start-and-end-key-are-contained-in-the-encode.patch
>
>
> Seems odd that region encoded name is same for regions if made in same second with same start key tough their end keys are different. It can happen in unit test. Should mix in the end key when coming up w/ the region name encoded name.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4382) Region encoded name is hash of
tablename + start key + regionid (timestamp); should include end key when
hashing.
Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127662#comment-13127662 ]
Ted Yu commented on HBASE-4382:
-------------------------------
@Alex:
See https://builds.apache.org/view/G-L/view/HBase/job/HBase-TRUNK/2322/
Since you're worried, I encourage you to spend some time on fixing the tests.
Stack logged a JIRA for TestAvroServer but I cannot find it.
> Region encoded name is hash of tablename + start key + regionid (timestamp); should include end key when hashing.
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4382
> URL: https://issues.apache.org/jira/browse/HBASE-4382
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: Alex Newman
> Labels: noob
> Attachments: 0001-HBASE-4382.-Region-encoded-name-is-hash-of-tablename.patch
>
>
> Seems odd that region encoded name is same for regions if made in same second with same start key tough their end keys are different. It can happen in unit test. Should mix in the end key when coming up w/ the region name encoded name.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4382) Region encoded name is hash of
tablename + start key + regionid (timestamp); should include end key when
hashing.
Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127653#comment-13127653 ]
Ted Yu commented on HBASE-4382:
-------------------------------
For createRegionName():
{code}
+ * @param endKey
{code}
endKey can be null, right ?
Please also put @return on its own line.
> Region encoded name is hash of tablename + start key + regionid (timestamp); should include end key when hashing.
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4382
> URL: https://issues.apache.org/jira/browse/HBASE-4382
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: Alex Newman
> Labels: noob
> Attachments: 0001-HBASE-4382.-Region-encoded-name-is-hash-of-tablename.patch
>
>
> Seems odd that region encoded name is same for regions if made in same second with same start key tough their end keys are different. It can happen in unit test. Should mix in the end key when coming up w/ the region name encoded name.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4382) Region encoded name is hash of
tablename + start key + regionid (timestamp); should include end key when
hashing.
Posted by "Alex Newman (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Newman updated HBASE-4382:
-------------------------------
Issue Type: Sub-task (was: Improvement)
Parent: HBASE-4616
> Region encoded name is hash of tablename + start key + regionid (timestamp); should include end key when hashing.
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4382
> URL: https://issues.apache.org/jira/browse/HBASE-4382
> Project: HBase
> Issue Type: Sub-task
> Reporter: stack
> Assignee: Alex Newman
> Labels: noob
>
> Seems odd that region encoded name is same for regions if made in same second with same start key tough their end keys are different. It can happen in unit test. Should mix in the end key when coming up w/ the region name encoded name.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4382) Region encoded name is hash of
tablename + start key + regionid (timestamp); should include end key when
hashing.
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126967#comment-13126967 ]
stack commented on HBASE-4382:
------------------------------
I think you are looking hashcode vs encoded name. See http://hbase.apache.org/xref/org/apache/hadoop/hbase/HRegionInfo.html#357
> Region encoded name is hash of tablename + start key + regionid (timestamp); should include end key when hashing.
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4382
> URL: https://issues.apache.org/jira/browse/HBASE-4382
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: Alex Newman
> Labels: noob
>
> Seems odd that region encoded name is same for regions if made in same second with same start key tough their end keys are different. It can happen in unit test. Should mix in the end key when coming up w/ the region name encoded name.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4382) Region encoded name is hash of
tablename + start key + regionid (timestamp); should include end key when
hashing.
Posted by "Alex Newman (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127642#comment-13127642 ]
Alex Newman commented on HBASE-4382:
------------------------------------
I should mention I am rerunning this through our hudson now.
The previous tests failed with
Failed
org.apache.hadoop.hbase.avro.TestAvroServer.testTableAdminAndMetadata
Failing for the past 2 builds (Since #3 )
Took 5.4 sec.
add description
Stacktrace
java.lang.AssertionError:
at org.junit.Assert.fail(Assert.java:91)
at org.junit.Assert.assertTrue(Assert.java:43)
at org.junit.Assert.assertTrue(Assert.java:54)
at org.apache.hadoop.hbase.avro.TestAvroServer.testTableAdminAndMetadata(TestAvroServer.java:132)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
at org.junit.internal.runners.statements.FailOnTimeout$1.run(FailOnTimeout.java:28)
org.apache.hadoop.hbase.avro.TestAvroServer.testFamilyAdminAndMetadata
Failing for the past 2 builds (Since #3 )
Took 35 ms.
add description
Stacktrace
org.apache.hadoop.hbase.avro.generated.ATableExists
at org.apache.hadoop.hbase.avro.AvroServer$HBaseImpl.createTable(AvroServer.java:255)
at org.apache.hadoop.hbase.avro.TestAvroServer.testFamilyAdminAndMetadata(TestAvroServer.java:161)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31)
at org.junit.runners.BlockJUnit4ClassRunner.runNotIgnored(BlockJUnit4ClassRunner.java:79)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:71)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:49)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31)
at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
at org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:53)
at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:123)
at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:104)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:164)
at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:110)
at org.apache.maven.surefire.booter.SurefireStarter.invokeProvider(SurefireStarter.java:172)
at org.apache.maven.surefire.booter.SurefireStarter.runSuitesInProcessWhenForked(SurefireStarter.java:78)
at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:70)
org.apache.hadoop.hbase.avro.TestAvroServer.testDML
Failing for the past 2 builds (Since #3 )
Took 17 ms.
add description
Stacktrace
org.apache.hadoop.hbase.avro.generated.ATableExists
at org.apache.hadoop.hbase.avro.AvroServer$HBaseImpl.createTable(AvroServer.java:255)
at org.apache.hadoop.hbase.avro.TestAvroServer.testDML(TestAvroServer.java:195)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31)
at org.junit.runners.BlockJUnit4ClassRunner.runNotIgnored(BlockJUnit4ClassRunner.java:79)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:71)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:49)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31)
at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
at org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:53)
at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:123)
at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:104)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:164)
at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:110)
at org.apache.maven.surefire.booter.SurefireStarter.invokeProvider(SurefireStarter.java:172)
at org.apache.maven.surefire.booter.SurefireStarter.runSuitesInProcessWhenForked(SurefireStarter.java:78)
at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:70)
> Region encoded name is hash of tablename + start key + regionid (timestamp); should include end key when hashing.
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4382
> URL: https://issues.apache.org/jira/browse/HBASE-4382
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: Alex Newman
> Labels: noob
> Attachments: 0001-HBASE-4382.-Region-encoded-name-is-hash-of-tablename.patch
>
>
> Seems odd that region encoded name is same for regions if made in same second with same start key tough their end keys are different. It can happen in unit test. Should mix in the end key when coming up w/ the region name encoded name.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4382) Region encoded name is hash of
tablename + start key + regionid (timestamp); should include end key when
hashing.
Posted by "Alex Newman (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127677#comment-13127677 ]
Alex Newman commented on HBASE-4382:
------------------------------------
So after removing the patch, doing a clean build and rerunning those tests I have the same errors. Maybe the tests are flakey. I'll :
1. wait for the next apache jenkins poll of hbase-trunk , to verify those tests are just broken and it's not just me.
2. Fix the javadoc comments.
before declaring this patch done.
> Region encoded name is hash of tablename + start key + regionid (timestamp); should include end key when hashing.
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4382
> URL: https://issues.apache.org/jira/browse/HBASE-4382
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: Alex Newman
> Labels: noob
> Attachments: 0001-HBASE-4382.-Region-encoded-name-is-hash-of-tablename.patch
>
>
> Seems odd that region encoded name is same for regions if made in same second with same start key tough their end keys are different. It can happen in unit test. Should mix in the end key when coming up w/ the region name encoded name.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4382) Region encoded name is hash of
tablename + start key + regionid (timestamp); should include end key when
hashing.
Posted by "Alex Newman (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126921#comment-13126921 ]
Alex Newman commented on HBASE-4382:
------------------------------------
Looks done to me
HRegionIinfo.java:
private void setHashCode() {
int result = Arrays.hashCode(this.regionName);
result ^= this.regionId;
result ^= Arrays.hashCode(this.startKey);
result ^= Arrays.hashCode(this.endKey);
result ^= Boolean.valueOf(this.offLine).hashCode();
result ^= Arrays.hashCode(this.tableName);
this.hashCode = result;
}
> Region encoded name is hash of tablename + start key + regionid (timestamp); should include end key when hashing.
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4382
> URL: https://issues.apache.org/jira/browse/HBASE-4382
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Labels: noob
>
> Seems odd that region encoded name is same for regions if made in same second with same start key tough their end keys are different. It can happen in unit test. Should mix in the end key when coming up w/ the region name encoded name.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4382) Region encoded name is hash of
tablename + start key + regionid (timestamp); should include end key when
hashing.
Posted by "Alex Newman (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126923#comment-13126923 ]
Alex Newman commented on HBASE-4382:
------------------------------------
Is there anything else we need to do here?
> Region encoded name is hash of tablename + start key + regionid (timestamp); should include end key when hashing.
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4382
> URL: https://issues.apache.org/jira/browse/HBASE-4382
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: Alex Newman
> Labels: noob
>
> Seems odd that region encoded name is same for regions if made in same second with same start key tough their end keys are different. It can happen in unit test. Should mix in the end key when coming up w/ the region name encoded name.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4382) Region encoded name is hash of
tablename + start key + regionid (timestamp); should include end key when
hashing.
Posted by "Alex Newman (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127993#comment-13127993 ]
Alex Newman commented on HBASE-4382:
------------------------------------
Ted agreed, although I might be missing something. I'd be more than happy to handle both.
> Region encoded name is hash of tablename + start key + regionid (timestamp); should include end key when hashing.
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4382
> URL: https://issues.apache.org/jira/browse/HBASE-4382
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: Alex Newman
> Labels: noob
>
> Seems odd that region encoded name is same for regions if made in same second with same start key tough their end keys are different. It can happen in unit test. Should mix in the end key when coming up w/ the region name encoded name.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4382) Region encoded name is hash of
tablename + start key + regionid (timestamp); should include end key when
hashing.
Posted by "Alex Newman (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Newman updated HBASE-4382:
-------------------------------
Attachment: (was: 0001-HBASE-2600.-Change-how-we-do-meta-tables-from-tablen.patch)
> Region encoded name is hash of tablename + start key + regionid (timestamp); should include end key when hashing.
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4382
> URL: https://issues.apache.org/jira/browse/HBASE-4382
> Project: HBase
> Issue Type: Sub-task
> Reporter: stack
> Assignee: Alex Newman
> Labels: noob
> Attachments: 0003-Verify-start-and-end-key-are-contained-in-the-encode.patch
>
>
> Seems odd that region encoded name is same for regions if made in same second with same start key tough their end keys are different. It can happen in unit test. Should mix in the end key when coming up w/ the region name encoded name.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4382) Region encoded name is hash of
tablename + start key + regionid (timestamp); should include end key when
hashing.
Posted by "Alex Newman (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Newman updated HBASE-4382:
-------------------------------
Status: Open (was: Patch Available)
> Region encoded name is hash of tablename + start key + regionid (timestamp); should include end key when hashing.
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4382
> URL: https://issues.apache.org/jira/browse/HBASE-4382
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: Alex Newman
> Labels: noob
>
> Seems odd that region encoded name is same for regions if made in same second with same start key tough their end keys are different. It can happen in unit test. Should mix in the end key when coming up w/ the region name encoded name.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira