You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by ZiyueHuang <gi...@git.apache.org> on 2017/06/12 06:24:36 UTC
[GitHub] spark pull request #18272: [DOCS] Fix error: ambiguous reference to overload...
GitHub user ZiyueHuang opened a pull request:
https://github.com/apache/spark/pull/18272
[DOCS] Fix error: ambiguous reference to overloaded definition
## What changes were proposed in this pull request?
`df.groupBy.count()` should be `df.groupBy().count()` , otherwise there is an error :
ambiguous reference to overloaded definition, both method groupBy in class Dataset of type (col1: String, cols: String*) and method groupBy in class Dataset of type (cols: org.apache.spark.sql.Column*)
## How was this patch tested?
```scala
val df = spark.readStream.schema(...).json(...)
val dfCounts =df.groupBy().count()
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ZiyueHuang/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/18272.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18272
----
commit 67dd3c75bce72bd320124b3b1a7585af40d18fb2
Author: Ziyue Huang <zy...@gmail.com>
Date: 2017-06-12T06:10:09Z
Fix error: ambiguous reference to overloaded definition, both method groupBy in class Dataset of type (col1: String, cols: String*) and (cols: org.apache.spark.sql.Column*)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18272: [DOCS] Fix error: ambiguous reference to overloaded defi...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18272
Hm, how do both match? the first one must have at least one String arg.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18272: [DOCS] Fix error: ambiguous reference to overloaded defi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18272
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18272: [DOCS] Fix error: ambiguous reference to overloaded defi...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18272
**[Test build #3791 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3791/testReport)** for PR 18272 at commit [`67dd3c7`](https://github.com/apache/spark/commit/67dd3c75bce72bd320124b3b1a7585af40d18fb2).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18272: [DOCS] Fix error: ambiguous reference to overloaded defi...
Posted by ZiyueHuang <gi...@git.apache.org>.
Github user ZiyueHuang commented on the issue:
https://github.com/apache/spark/pull/18272
@srowen Ambiguity is due to the lack of parentheses behind groupBy. So it should be `df.groupBy().count()`, not `df.groupBy.count()`, otherwise there is an error of ambiguity. I have tested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #18272: [DOCS] Fix error: ambiguous reference to overload...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18272
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18272: [DOCS] Fix error: ambiguous reference to overloaded defi...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18272
**[Test build #3791 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3791/testReport)** for PR 18272 at commit [`67dd3c7`](https://github.com/apache/spark/commit/67dd3c75bce72bd320124b3b1a7585af40d18fb2).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18272: [DOCS] Fix error: ambiguous reference to overloaded defi...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18272
Merged to master/2.2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18272: [DOCS] Fix error: ambiguous reference to overloaded defi...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18272
OK yeah I tried it and the error is a little more specifically that you can't invoke a varargs method this way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org