You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/11/10 17:35:26 UTC
[GitHub] [cloudstack] stephankruggg opened a new pull request, #6893: Fix recurring snapshot form time format
stephankruggg opened a new pull request, #6893:
URL: https://github.com/apache/cloudstack/pull/6893
### Description
This PR changes the time format used in the recurring snapshot form to the 24-hour time format, as the current 12-hour time format is not the ACS standard.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [X] Trivial
### Screenshots (if appropriate):
Before:
After:
### How Has This Been Tested?
I applied the changes in a local lab, and checked if the time format was displayed correctly and if the time was saved and processed properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] stephankruggg commented on pull request #6893: Fix recurring snapshot form time format
Posted by GitBox <gi...@apache.org>.
stephankruggg commented on PR #6893:
URL: https://github.com/apache/cloudstack/pull/6893#issuecomment-1313628964
> I am approving this because it is my preference as well, but wouldn´t it be a user preference or at least an operator preference? We might want to consider this as configurable.
I have based myself upon current ACS presentation standards, such as the examples below. But yes, I agree that after normalization it could be interesting to add a way to specify the format and apply it everywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #6893: Fix recurring snapshot form time format
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged PR #6893:
URL: https://github.com/apache/cloudstack/pull/6893
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6893: Fix recurring snapshot form time format
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6893:
URL: https://github.com/apache/cloudstack/pull/6893#issuecomment-1310652233
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #6893: Fix recurring snapshot form time format
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #6893:
URL: https://github.com/apache/cloudstack/pull/6893#issuecomment-1310731009
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6893?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6893](https://codecov.io/gh/apache/cloudstack/pull/6893?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f6c1c4c) into [main](https://codecov.io/gh/apache/cloudstack/commit/982450ed81bd1e08797598e02cbd17b76bab3b22?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (982450e) will **not change** coverage.
> The diff coverage is `88.88%`.
```diff
@@ Coverage Diff @@
## main #6893 +/- ##
=========================================
Coverage 10.87% 10.87%
Complexity 7117 7117
=========================================
Files 2485 2485
Lines 245499 245499
Branches 38334 38334
=========================================
Hits 26699 26699
Misses 215530 215530
Partials 3270 3270
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6893?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../src/main/java/com/cloud/vm/UserVmManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6893/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3ZtL1VzZXJWbU1hbmFnZXJJbXBsLmphdmE=) | `6.72% <0.00%> (ø)` | |
| [...tionrule/presetvariables/PresetVariableHelper.java](https://codecov.io/gh/apache/cloudstack/pull/6893/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZnJhbWV3b3JrL3F1b3RhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3F1b3RhL2FjdGl2YXRpb25ydWxlL3ByZXNldHZhcmlhYmxlcy9QcmVzZXRWYXJpYWJsZUhlbHBlci5qYXZh) | `98.56% <100.00%> (ø)` | |
| [...ervisor/kvm/resource/LibvirtComputingResource.java](https://codecov.io/gh/apache/cloudstack/pull/6893/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2UvTGlidmlydENvbXB1dGluZ1Jlc291cmNlLmphdmE=) | `17.03% <100.00%> (ø)` | |
| [...resource/wrapper/LibvirtScaleVmCommandWrapper.java](https://codecov.io/gh/apache/cloudstack/pull/6893/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2Uvd3JhcHBlci9MaWJ2aXJ0U2NhbGVWbUNvbW1hbmRXcmFwcGVyLmphdmE=) | `94.11% <100.00%> (ø)` | |
| [...er/src/main/java/com/cloud/hypervisor/KVMGuru.java](https://codecov.io/gh/apache/cloudstack/pull/6893/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2h5cGVydmlzb3IvS1ZNR3VydS5qYXZh) | `73.22% <100.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6893: Fix recurring snapshot form time format
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6893:
URL: https://github.com/apache/cloudstack/pull/6893#issuecomment-1310653079
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6893: Fix recurring snapshot form time format
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6893:
URL: https://github.com/apache/cloudstack/pull/6893#issuecomment-1310659120
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6893 (LL-JID-224)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org