You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/04/14 16:52:50 UTC

[GitHub] [tvm] leandron commented on a change in pull request #7823: [TVMC] A simplified TVMC API for python scripting.

leandron commented on a change in pull request #7823:
URL: https://github.com/apache/tvm/pull/7823#discussion_r613414355



##########
File path: python/tvm/driver/tvmc/runner.py
##########
@@ -112,8 +112,10 @@ def drive_run(args):
     except IOError as ex:
         raise TVMCException("Error loading inputs file: %s" % ex)
 
-    outputs, times = run_module(
-        args.FILE,
+    tvmc_package = TVMCPackage(package_path=args.FILE)

Review comment:
       I see this as a breaking change with the existing output format. I'm flagging this here to see what others think on whether we should maintain compatibility with our existing custom format or we might as well do the move and use the official APIs and abandon the custom implementation.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org