You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/08/16 05:34:09 UTC
[GitHub] [spark] PavithraRamachandran commented on a change in pull request
#25394: [SPARK-28671][SQL] Throw NoSuchPermanentFunctionException for a
non-exsistent permanent function in dropFunction
PavithraRamachandran commented on a change in pull request #25394: [SPARK-28671][SQL] Throw NoSuchPermanentFunctionException for a non-exsistent permanent function in dropFunction
URL: https://github.com/apache/spark/pull/25394#discussion_r314588046
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
##########
@@ -1114,7 +1114,7 @@ class SessionCatalog(
}
externalCatalog.dropFunction(db, name.funcName)
} else if (!ignoreIfNotExists) {
- throw new NoSuchFunctionException(db = db, func = identifier.toString)
+ throw new NoSuchPermanentFunctionException(db = db, func = identifier.toString)
Review comment:
In catalog dropTempFunction is present to handle temp function .
in dropTempFunction - **NoSuchTempFunctionException** exception is getting thrown
both functions throws different exceptions , is it required to change in dropTempFunction?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org