You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by "hujianhong (via GitHub)" <gi...@apache.org> on 2023/07/21 02:14:47 UTC

[GitHub] [calcite] hujianhong commented on pull request #3292: [CALCITE-5807] Add SUBSTRING_INDEX function (enabled in Spark library)

hujianhong commented on PR #3292:
URL: https://github.com/apache/calcite/pull/3292#issuecomment-1644892032

   > Hi @hujianhong , left some comments. One small tip: before the final squash and rebase, please don't force push your commit. It helps other reviewers to see the differences.
   
   I'm sorry. This is my first PR for calcite. I will be careful in the future.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org