[GitHub] [cloudstack] GutoVeronezi commented on a diff in pull request #6868: Set root volume as destroyed when destroying a VM

[GitBox <gi...@apache.org>]

GutoVeronezi commented on code in PR #6868:
URL: https://github.com/apache/cloudstack/pull/6868#discussion_r1018245216


##########
server/src/main/java/com/cloud/vm/UserVmManager.java:
##########
@@ -55,6 +55,10 @@ public interface UserVmManager extends UserVmService {
     ConfigKey<Boolean> DisplayVMOVFProperties = new ConfigKey<Boolean>("Advanced", Boolean.class, "vm.display.ovf.properties", "false",
             "Set display of VMs OVF properties as part of VM details", true);
 
+    ConfigKey<Boolean> DestroyRootVolumeOnVmDestruction = new ConfigKey<Boolean>("Advanced", Boolean.class, "destroy.root.volume.on.vm.destruction", "false",
+            "Destroys the VM's root volume when the VM is destroyed. When set to true, volume cleanup task will not expunge destroyed volumes, but the VM cleanup task will.",

Review Comment:
   ```suggestion
               "Indicates whether the VM's ROOT volume will be marked as 'Destroy' when the VM is destroyed. When set to false (default), the current behavior will be kept (the volume will continue as 'Ready' and the volume cleanup task will expunge it). When set to true, the volume will be marked as `Destroy` and the VM cleanup task will expunge it along with the VM (the volume cleanup task will not expunge it).",
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org