You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Charles Reiss <wo...@gmail.com> on 2012/01/23 04:33:37 UTC
Review Request: Make 'make clean' clean more generated files.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3587/
-----------------------------------------------------------
Review request for mesos.
Summary
-------
'make clean' is currently missing a few generated files; this adds them.
Also makes mesos_pb2.py be generated directly in python/src instead of being copied there.
Part of MESOS-120 because this is necessary for 'make distcheck' to pass.
This addresses bug MESOS-120.
https://issues.apache.org/jira/browse/MESOS-120
Diffs
-----
src/Makefile.am b8fc58e
Diff: https://reviews.apache.org/r/3587/diff
Testing
-------
Thanks,
Charles
Re: Review Request: Make 'make clean' clean more generated files.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3587/#review4728
-----------------------------------------------------------
Ship it!
Okay, I'm really submitting it this time.
- Benjamin
On 2012-02-01 00:35:56, Charles Reiss wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3587/
> -----------------------------------------------------------
>
> (Updated 2012-02-01 00:35:56)
>
>
> Review request for mesos.
>
>
> Summary
> -------
>
> 'make clean' is currently missing a few generated files; this adds them.
>
> Also makes mesos_pb2.py be generated directly in python/src instead of being copied there.
>
> Part of MESOS-120 because this is necessary for 'make distcheck' to pass.
>
>
> This addresses bug MESOS-120.
> https://issues.apache.org/jira/browse/MESOS-120
>
>
> Diffs
> -----
>
> src/Makefile.am 48727ae
>
> Diff: https://reviews.apache.org/r/3587/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Charles
>
>
Re: Review Request: Make 'make clean' clean more generated files.
Posted by Charles Reiss <wo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3587/
-----------------------------------------------------------
(Updated 2012-02-01 00:35:56.677615)
Review request for mesos.
Summary
-------
'make clean' is currently missing a few generated files; this adds them.
Also makes mesos_pb2.py be generated directly in python/src instead of being copied there.
Part of MESOS-120 because this is necessary for 'make distcheck' to pass.
This addresses bug MESOS-120.
https://issues.apache.org/jira/browse/MESOS-120
Diffs (updated)
-----
src/Makefile.am 48727ae
Diff: https://reviews.apache.org/r/3587/diff
Testing
-------
Thanks,
Charles
Re: Review Request: Make 'make clean' clean more generated files.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3587/#review4628
-----------------------------------------------------------
Ship it!
Cool, I'll get this committed.
- Benjamin
On 2012-01-26 02:23:30, Charles Reiss wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3587/
> -----------------------------------------------------------
>
> (Updated 2012-01-26 02:23:30)
>
>
> Review request for mesos.
>
>
> Summary
> -------
>
> 'make clean' is currently missing a few generated files; this adds them.
>
> Also makes mesos_pb2.py be generated directly in python/src instead of being copied there.
>
> Part of MESOS-120 because this is necessary for 'make distcheck' to pass.
>
>
> This addresses bug MESOS-120.
> https://issues.apache.org/jira/browse/MESOS-120
>
>
> Diffs
> -----
>
> src/Makefile.am 48727ae
>
> Diff: https://reviews.apache.org/r/3587/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Charles
>
>
Re: Review Request: Make 'make clean' clean more generated files.
Posted by Charles Reiss <wo...@gmail.com>.
> On 2012-01-31 23:59:33, Benjamin Hindman wrote:
> > src/Makefile.am, line 547
> > <https://reviews.apache.org/r/3587/diff/2/?file=70825#file70825line547>
> >
> > So we can kill this line now correct?
Yes. Done.
- Charles
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3587/#review4723
-----------------------------------------------------------
On 2012-02-01 00:35:56, Charles Reiss wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3587/
> -----------------------------------------------------------
>
> (Updated 2012-02-01 00:35:56)
>
>
> Review request for mesos.
>
>
> Summary
> -------
>
> 'make clean' is currently missing a few generated files; this adds them.
>
> Also makes mesos_pb2.py be generated directly in python/src instead of being copied there.
>
> Part of MESOS-120 because this is necessary for 'make distcheck' to pass.
>
>
> This addresses bug MESOS-120.
> https://issues.apache.org/jira/browse/MESOS-120
>
>
> Diffs
> -----
>
> src/Makefile.am 48727ae
>
> Diff: https://reviews.apache.org/r/3587/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Charles
>
>
Re: Review Request: Make 'make clean' clean more generated files.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3587/#review4723
-----------------------------------------------------------
src/Makefile.am
<https://reviews.apache.org/r/3587/#comment10439>
So we can kill this line now correct?
- Benjamin
On 2012-01-26 02:23:30, Charles Reiss wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3587/
> -----------------------------------------------------------
>
> (Updated 2012-01-26 02:23:30)
>
>
> Review request for mesos.
>
>
> Summary
> -------
>
> 'make clean' is currently missing a few generated files; this adds them.
>
> Also makes mesos_pb2.py be generated directly in python/src instead of being copied there.
>
> Part of MESOS-120 because this is necessary for 'make distcheck' to pass.
>
>
> This addresses bug MESOS-120.
> https://issues.apache.org/jira/browse/MESOS-120
>
>
> Diffs
> -----
>
> src/Makefile.am 48727ae
>
> Diff: https://reviews.apache.org/r/3587/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Charles
>
>
Re: Review Request: Make 'make clean' clean more generated files.
Posted by Charles Reiss <wo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3587/
-----------------------------------------------------------
(Updated 2012-01-26 02:23:30.841463)
Review request for mesos.
Summary
-------
'make clean' is currently missing a few generated files; this adds them.
Also makes mesos_pb2.py be generated directly in python/src instead of being copied there.
Part of MESOS-120 because this is necessary for 'make distcheck' to pass.
This addresses bug MESOS-120.
https://issues.apache.org/jira/browse/MESOS-120
Diffs (updated)
-----
src/Makefile.am 48727ae
Diff: https://reviews.apache.org/r/3587/diff
Testing
-------
Thanks,
Charles
Re: Review Request: Make 'make clean' clean more generated files.
Posted by Charles Reiss <wo...@gmail.com>.
> On 2012-01-24 21:23:29, Benjamin Hindman wrote:
> > src/Makefile.am, line 387
> > <https://reviews.apache.org/r/3587/diff/1/?file=70255#file70255line387>
> >
> > If we don't build with java, does 'make clean' complain if these don't exist? What's the cons to sticking all the clean stuff (including the clean-java/clean-python) targets within 'if HAS_JAVA' (or 'if HAS_PYTHON')?
>
> Charles Reiss wrote:
> make clean needs to work even if you didn't build, so it shouldn't.
>
> Benjamin Hindman wrote:
> If we need 'clean-java' to be outside of the 'if HAS_JAVA' block, then I think it should be at the bottom of that block to make it easier to understand. Likewise, we can put CLEANFILES for MESOS_JAR and EXAMPLES_JAR inside the if HAS_JAVA block next to their targets (in fact, I think MESOS_JAR was already there, but not by itself). Likewise, I'd like to move the clean-python one too.
Moved clean-java and clean-python blocks to after the HAS_* blocks, and CLEANFILES additions to the HAS_* blocks.
- Charles
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3587/#review4561
-----------------------------------------------------------
On 2012-01-26 02:23:30, Charles Reiss wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3587/
> -----------------------------------------------------------
>
> (Updated 2012-01-26 02:23:30)
>
>
> Review request for mesos.
>
>
> Summary
> -------
>
> 'make clean' is currently missing a few generated files; this adds them.
>
> Also makes mesos_pb2.py be generated directly in python/src instead of being copied there.
>
> Part of MESOS-120 because this is necessary for 'make distcheck' to pass.
>
>
> This addresses bug MESOS-120.
> https://issues.apache.org/jira/browse/MESOS-120
>
>
> Diffs
> -----
>
> src/Makefile.am 48727ae
>
> Diff: https://reviews.apache.org/r/3587/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Charles
>
>
Re: Review Request: Make 'make clean' clean more generated files.
Posted by Charles Reiss <wo...@gmail.com>.
> On 2012-01-24 21:23:29, Benjamin Hindman wrote:
> > src/Makefile.am, line 387
> > <https://reviews.apache.org/r/3587/diff/1/?file=70255#file70255line387>
> >
> > If we don't build with java, does 'make clean' complain if these don't exist? What's the cons to sticking all the clean stuff (including the clean-java/clean-python) targets within 'if HAS_JAVA' (or 'if HAS_PYTHON')?
make clean needs to work even if you didn't build, so it shouldn't.
> On 2012-01-24 21:23:29, Benjamin Hindman wrote:
> > src/Makefile.am, line 677
> > <https://reviews.apache.org/r/3587/diff/1/?file=70255#file70255line677>
> >
> > Does 'make check' create the test_output directory?
The external tests create it somehow, I don't know the exact mechanism offhand.
> On 2012-01-24 21:23:29, Benjamin Hindman wrote:
> > src/Makefile.am, line 508
> > <https://reviews.apache.org/r/3587/diff/1/?file=70255#file70255line508>
> >
> > Why is this needed?
The distribution will tar most things up without write permission set. cp -pf will preserve this, so python/native will contain many read-only files.
- Charles
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3587/#review4561
-----------------------------------------------------------
On 2012-01-23 03:33:37, Charles Reiss wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3587/
> -----------------------------------------------------------
>
> (Updated 2012-01-23 03:33:37)
>
>
> Review request for mesos.
>
>
> Summary
> -------
>
> 'make clean' is currently missing a few generated files; this adds them.
>
> Also makes mesos_pb2.py be generated directly in python/src instead of being copied there.
>
> Part of MESOS-120 because this is necessary for 'make distcheck' to pass.
>
>
> This addresses bug MESOS-120.
> https://issues.apache.org/jira/browse/MESOS-120
>
>
> Diffs
> -----
>
> src/Makefile.am b8fc58e
>
> Diff: https://reviews.apache.org/r/3587/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Charles
>
>
Re: Review Request: Make 'make clean' clean more generated files.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On 2012-01-24 21:23:29, Benjamin Hindman wrote:
> > src/Makefile.am, line 387
> > <https://reviews.apache.org/r/3587/diff/1/?file=70255#file70255line387>
> >
> > If we don't build with java, does 'make clean' complain if these don't exist? What's the cons to sticking all the clean stuff (including the clean-java/clean-python) targets within 'if HAS_JAVA' (or 'if HAS_PYTHON')?
>
> Charles Reiss wrote:
> make clean needs to work even if you didn't build, so it shouldn't.
If we need 'clean-java' to be outside of the 'if HAS_JAVA' block, then I think it should be at the bottom of that block to make it easier to understand. Likewise, we can put CLEANFILES for MESOS_JAR and EXAMPLES_JAR inside the if HAS_JAVA block next to their targets (in fact, I think MESOS_JAR was already there, but not by itself). Likewise, I'd like to move the clean-python one too.
> On 2012-01-24 21:23:29, Benjamin Hindman wrote:
> > src/Makefile.am, line 508
> > <https://reviews.apache.org/r/3587/diff/1/?file=70255#file70255line508>
> >
> > Why is this needed?
>
> Charles Reiss wrote:
> The distribution will tar most things up without write permission set. cp -pf will preserve this, so python/native will contain many read-only files.
Gotcha, thanks.
> On 2012-01-24 21:23:29, Benjamin Hindman wrote:
> > src/Makefile.am, line 677
> > <https://reviews.apache.org/r/3587/diff/1/?file=70255#file70255line677>
> >
> > Does 'make check' create the test_output directory?
>
> Charles Reiss wrote:
> The external tests create it somehow, I don't know the exact mechanism offhand.
Right.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3587/#review4561
-----------------------------------------------------------
On 2012-01-23 03:33:37, Charles Reiss wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3587/
> -----------------------------------------------------------
>
> (Updated 2012-01-23 03:33:37)
>
>
> Review request for mesos.
>
>
> Summary
> -------
>
> 'make clean' is currently missing a few generated files; this adds them.
>
> Also makes mesos_pb2.py be generated directly in python/src instead of being copied there.
>
> Part of MESOS-120 because this is necessary for 'make distcheck' to pass.
>
>
> This addresses bug MESOS-120.
> https://issues.apache.org/jira/browse/MESOS-120
>
>
> Diffs
> -----
>
> src/Makefile.am b8fc58e
>
> Diff: https://reviews.apache.org/r/3587/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Charles
>
>
Re: Review Request: Make 'make clean' clean more generated files.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3587/#review4561
-----------------------------------------------------------
Just a few quick questions.
src/Makefile.am
<https://reviews.apache.org/r/3587/#comment10183>
If we don't build with java, does 'make clean' complain if these don't exist? What's the cons to sticking all the clean stuff (including the clean-java/clean-python) targets within 'if HAS_JAVA' (or 'if HAS_PYTHON')?
src/Makefile.am
<https://reviews.apache.org/r/3587/#comment10182>
Why is this needed?
src/Makefile.am
<https://reviews.apache.org/r/3587/#comment10184>
Does 'make check' create the test_output directory?
- Benjamin
On 2012-01-23 03:33:37, Charles Reiss wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3587/
> -----------------------------------------------------------
>
> (Updated 2012-01-23 03:33:37)
>
>
> Review request for mesos.
>
>
> Summary
> -------
>
> 'make clean' is currently missing a few generated files; this adds them.
>
> Also makes mesos_pb2.py be generated directly in python/src instead of being copied there.
>
> Part of MESOS-120 because this is necessary for 'make distcheck' to pass.
>
>
> This addresses bug MESOS-120.
> https://issues.apache.org/jira/browse/MESOS-120
>
>
> Diffs
> -----
>
> src/Makefile.am b8fc58e
>
> Diff: https://reviews.apache.org/r/3587/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Charles
>
>