You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Rahul Akolkar <ra...@gmail.com> on 2009/07/14 17:49:48 UTC
[JEXL] Unified syntax and 2.0 release (was: Is JEXL ...)
Please change the subject or start a new thread where appropriate.
On Tue, Jul 14, 2009 at 6:49 AM, Henrib<hb...@gmail.com> wrote:
>
>
> I've created JEXL-58 to fix some last details and added a Unified EL (ala
> JSP/JSF, supporting immediate/deferred & nested expressions) that "proves"
> the extensibility & should make things easier for those of us dealing with
> the dollar-sharp syntax :-). Christian, Rahul & others, comments/review
> welcome.
>
<snip/>
This is useful. I'd like to suggest we call the class UnifiedJEXL
(ofcourse, there is no "unification" in JEXL, but I think it will be
unambiguous and still convey the right meaning at the same time --
atleast it does so for me).
At a quick glance, I only have some minor nits with the patch:
* Some files have whitespace only changes (Asserter.java, ScriptFactory.java)
* I'd avoid changing imports style where not strictly necessary (Debugger.java)
* Some changes WRT throws clauses in signatures (whether thats
strictly necessary)
* In spirit with surrounding code, braces for ifs
> Are there any bugs/enhancements that should still be tackled before we
> attempt to release 2.0 ?
<snap/>
Ideally, it'd be good to go over everything in JIRA and resolve it
(which doesn't mean fixing everything, could be deferred, won't fixes,
invalids etc.).
> It seems most of the pending issues are covered somehow by the 2.0 codebase;
> anyone using JEXL in -may be- Jelly? / Hive? / Scriptella / Junit- having a
> different point of view?
>
> What should be the next steps ?
>
<snip/>
Along the lines of:
* Triage JIRA, improve test coverage (where needed) -- help is needed
for this step :-)
* Publish intent to produce v2.0, solicit feedback (such as here)
* Produce RC when above points are done towards eventual release
-Rahul
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [JEXL] Unified syntax and 2.0 release (was: Is JEXL ...)
Posted by Henrib <hb...@gmail.com>.
You're right, I'm sorry for the imprecision.
What I meant was that the "official / Apache approved for projects" Maven
version will have to be 2.2 (to be able to check the generic
whitespace/checkstyle 5.0 based plugin yet to be released); I just dont know
which Maven version we are supposed to use but suspect it is not 2.2 since
it's pretty young.
Hopes it makes more sense.
--
View this message in context: http://www.nabble.com/-JEXL--Unified-syntax-and-2.0-release-%28was%3A-Is-JEXL-...%29-tp24482461p24533985.html
Sent from the Commons - Dev mailing list archive at Nabble.com.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [JEXL] Unified syntax and 2.0 release (was: Is JEXL ...)
Posted by Jörg Schaible <jo...@gmx.de>.
Henrib wrote at Donnerstag, 16. Juli 2009 21:16:
[snip]
> Furthermore, I suppose that the maven version we are supposed to use is
> not 2.2 (which drops java 1.4 support) which will probably be required for
> the "checkstyle 5.0" plugin.
Why's that? You can run any M2 version with Java 5. It's only that M22 will
no longer run with pre JDK 5.
- Jörg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [JEXL] Unified syntax and 2.0 release (was: Is JEXL ...)
Posted by Rahul Akolkar <ra...@gmail.com>.
On Thu, Jul 16, 2009 at 3:16 PM, Henrib<hb...@gmail.com> wrote:
>
> Rahul Akolkar wrote:
>>
>> Build the site (mvn site) and look for the checkstyle report.
>>
>
> Thanks for pointing the 'mvn site' & al.
>
> It seems the rules for checkstyle predate Java5 code and the maven plugin is
> not yet able to deal correctly with generics (ie <module
> name="GenericWhitespace"/> ) as I found here
> http://jira.codehaus.org/browse/MCHECKSTYLE-105.
> Furthermore, I suppose that the maven version we are supposed to use is not
> 2.2 (which drops java 1.4 support) which will probably be required for the
> "checkstyle 5.0" plugin.
>
> Anyway, the problem is that each corrected "raw type usage" introduces more
> errors on "checkstyle"...
> Any suggested course of action or preference?
<snip/>
Its always possible to run checkstyle off its jar, but thats not as
convenient. I think twiddling the whitespace rules as you've done is
just fine here.
-Rahul
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [JEXL] Unified syntax and 2.0 release (was: Is JEXL ...)
Posted by Henrib <hb...@gmail.com>.
Rahul Akolkar wrote:
>
> Build the site (mvn site) and look for the checkstyle report.
>
Thanks for pointing the 'mvn site' & al.
It seems the rules for checkstyle predate Java5 code and the maven plugin is
not yet able to deal correctly with generics (ie <module
name="GenericWhitespace"/> ) as I found here
http://jira.codehaus.org/browse/MCHECKSTYLE-105.
Furthermore, I suppose that the maven version we are supposed to use is not
2.2 (which drops java 1.4 support) which will probably be required for the
"checkstyle 5.0" plugin.
Anyway, the problem is that each corrected "raw type usage" introduces more
errors on "checkstyle"...
Any suggested course of action or preference?
--
View this message in context: http://www.nabble.com/-JEXL--Unified-syntax-and-2.0-release-%28was%3A-Is-JEXL-...%29-tp24482461p24522734.html
Sent from the Commons - Dev mailing list archive at Nabble.com.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [JEXL] Unified syntax and 2.0 release (was: Is JEXL ...)
Posted by Rahul Akolkar <ra...@gmail.com>.
On Wed, Jul 15, 2009 at 9:49 AM, Henrib<hb...@gmail.com> wrote:
>
>
>
> Rahul Akolkar wrote:
>>
>> Also, since the 2.0 branch has moved to JDK 1.5, might make sense to
>> look at the hundreds of raw types usage and other warnings etc (if
>> someone has cycles to allocate, that is).
>>
>
> I'm not sure I understand what you mean; my apologies if I'm missing the
> obvious.
> Should we be searching for non-generic collection usage or ...?
> I dont see "warnings" at compilation time; is there some tool / target in
> the pom that generates these?
<snip/>
I just pulled it up in Eclipse, so the right compiler and setting will
get you those warnings. Mostly to do with type safety improvements on
Collections classes. So, for example, 1 (of 337) is:
AbstractList is a raw type. References to generic type AbstractList<E>
should be parameterized jexl2/src/java/org/apache/commons/jexl/util ArrayListWrapper.java
line 28
Most, if not all of these, can be corrected. Ofcourse, we'll ignore
any generated classes.
> Which brings me to the another question (initiated byJEXL-20); is there a
> checkstyle goal for instance that I should know about ?
> Thanks.
<snap/>
Build the site (mvn site) and look for the checkstyle report. Here is
what we have online:
http://commons.apache.org/jexl/checkstyle.html
Before release, we will need to do as much static analysis as possible
(checkstyle, PMD, Findbugs etc. -- most are m2 plugins that can
produce site reports) in addition to test coverage (Cobertura and co.)
and compatibility (Clirr and friends). Last one doesn't apply to new
code ofcourse.
-Rahul
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [JEXL] Unified syntax and 2.0 release (was: Is JEXL ...)
Posted by Henrib <hb...@gmail.com>.
Rahul Akolkar wrote:
>
> Also, since the 2.0 branch has moved to JDK 1.5, might make sense to
> look at the hundreds of raw types usage and other warnings etc (if
> someone has cycles to allocate, that is).
>
I'm not sure I understand what you mean; my apologies if I'm missing the
obvious.
Should we be searching for non-generic collection usage or ...?
I dont see "warnings" at compilation time; is there some tool / target in
the pom that generates these?
Which brings me to the another question (initiated byJEXL-20); is there a
checkstyle goal for instance that I should know about ?
Thanks.
--
View this message in context: http://www.nabble.com/-JEXL--Unified-syntax-and-2.0-release-%28was%3A-Is-JEXL-...%29-tp24482461p24498273.html
Sent from the Commons - Dev mailing list archive at Nabble.com.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [JEXL] Unified syntax and 2.0 release (was: Is JEXL ...)
Posted by Rahul Akolkar <ra...@gmail.com>.
On Tue, Jul 14, 2009 at 11:49 AM, Rahul Akolkar<ra...@gmail.com> wrote:
> On Tue, Jul 14, 2009 at 6:49 AM, Henrib<hb...@gmail.com> wrote:
<snip/>
>>
>> What should be the next steps ?
>>
>
> Along the lines of:
> * Triage JIRA, improve test coverage (where needed) -- help is needed
> for this step :-)
<snap/>
Also, since the 2.0 branch has moved to JDK 1.5, might make sense to
look at the hundreds of raw types usage and other warnings etc (if
someone has cycles to allocate, that is).
-Rahul
> * Publish intent to produce v2.0, solicit feedback (such as here)
> * Produce RC when above points are done towards eventual release
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org