You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Darryl L. Pierce" <dp...@redhat.com> on 2013/04/08 16:05:21 UTC

0.22 Inclusion Request - QPID-4698

Fixes needed for the CMake build system when installing files.

Corrects the installation for several pieces, including Python site
packages, a couple of configuration files and a SysVInit script.

http://issues.apache.org/jira/browse/QPID-4698

-- 
Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/


Re: 0.22 Inclusion Request - QPID-4698

Posted by Justin Ross <ju...@gmail.com>.
It has indeed.  I've added a reference to the subsequent fix to the
original patch and approved it for 0.22.

On Tue, Apr 30, 2013 at 10:31 AM, Darryl L. Pierce <dp...@redhat.com> wrote:
> On Mon, Apr 08, 2013 at 10:05:21AM -0400, Darryl L. Pierce wrote:
>> Fixes needed for the CMake build system when installing files.
>>
>> Corrects the installation for several pieces, including Python site
>> packages, a couple of configuration files and a SysVInit script.
>>
>> http://issues.apache.org/jira/browse/QPID-4698
>
> Has this been reconsidered for inclusion in 0.22?
>
> --
> Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
> Delivering value year after year.
> Red Hat ranks #1 in value among software vendors.
> http://www.redhat.com/promo/vendor/
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Re: 0.22 Inclusion Request - QPID-4698

Posted by "Darryl L. Pierce" <dp...@redhat.com>.
On Mon, Apr 08, 2013 at 10:05:21AM -0400, Darryl L. Pierce wrote:
> Fixes needed for the CMake build system when installing files.
> 
> Corrects the installation for several pieces, including Python site
> packages, a couple of configuration files and a SysVInit script.
> 
> http://issues.apache.org/jira/browse/QPID-4698

Has this been reconsidered for inclusion in 0.22?

-- 
Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/


Re: 0.22 Inclusion Request - QPID-4698

Posted by "Darryl L. Pierce" <dp...@redhat.com>.
On Tue, Apr 09, 2013 at 10:11:53AM -0400, Alan Conway wrote:
> On 04/08/2013 10:05 AM, Darryl L. Pierce wrote:
> >Fixes needed for the CMake build system when installing files.
> >
> >Corrects the installation for several pieces, including Python site
> >packages, a couple of configuration files and a SysVInit script.
> >
> >http://issues.apache.org/jira/browse/QPID-4698
> >
> 
> Should the last line also be changed to use @...@?

You're right. I missed that since it was in the comment.

> 
> --- qpid/trunk/qpid/cpp/etc/qpidd-primary.in	2013/04/08 14:01:44	1465642
> +++ qpid/trunk/qpid/cpp/etc/qpidd-primary.in	2013/04/08 14:02:18	1465643
> @@ -40,8 +40,8 @@
>  # Source function library.
>  . /etc/rc.d/init.d/functions
> 
> -if [ -f !!sysconfdir!!/sysconfig/$prog ] ; then
> -    . !!sysconfdir!!/sysconfig/$prog
> +if [ -f @sysconfdir@/sysconfig/$prog ] ; then
> +    . @sysconfdir@/sysconfig/$prog
>  fi
> 
>  # The following variables can be overridden in !!sysconfdir!!/sysconfig/$prog

-- 
Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/


Re: 0.22 Inclusion Request - QPID-4698

Posted by Alan Conway <ac...@redhat.com>.
On 04/08/2013 10:05 AM, Darryl L. Pierce wrote:
> Fixes needed for the CMake build system when installing files.
>
> Corrects the installation for several pieces, including Python site
> packages, a couple of configuration files and a SysVInit script.
>
> http://issues.apache.org/jira/browse/QPID-4698
>

Should the last line also be changed to use @...@?

--- qpid/trunk/qpid/cpp/etc/qpidd-primary.in	2013/04/08 14:01:44	1465642
+++ qpid/trunk/qpid/cpp/etc/qpidd-primary.in	2013/04/08 14:02:18	1465643
@@ -40,8 +40,8 @@
  # Source function library.
  . /etc/rc.d/init.d/functions

-if [ -f !!sysconfdir!!/sysconfig/$prog ] ; then
-    . !!sysconfdir!!/sysconfig/$prog
+if [ -f @sysconfdir@/sysconfig/$prog ] ; then
+    . @sysconfdir@/sysconfig/$prog
  fi

  # The following variables can be overridden in !!sysconfdir!!/sysconfig/$prog

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org