You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/12/11 18:38:56 UTC
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8720:
Require the SQLAlchemy URI on the database model
codecov-io edited a comment on issue #8720: Require the SQLAlchemy URI on the database model
URL: https://github.com/apache/incubator-superset/pull/8720#issuecomment-560949459
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8720?src=pr&el=h1) Report
> Merging [#8720](https://codecov.io/gh/apache/incubator-superset/pull/8720?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6c130b32ad9c2f75a879aa39bde9fff44351f6e4?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/8720?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8720 +/- ##
=========================================
- Coverage 65.9% 65.9% -0.01%
=========================================
Files 483 483
Lines 24163 24165 +2
Branches 2770 2770
=========================================
Hits 15925 15925
- Misses 8060 8062 +2
Partials 178 178
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8720?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8720/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `83.09% <ø> (ø)` | :arrow_up: |
| [superset/models/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/8720/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NjaGVkdWxlcy5weQ==) | `88.88% <0%> (-2.03%)` | :arrow_down: |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/8720/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `77.57% <0%> (-0.47%)` | :arrow_down: |
| [superset/views/datasource.py](https://codecov.io/gh/apache/incubator-superset/pull/8720/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==) | `96.07% <0%> (-0.08%)` | :arrow_down: |
| [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/8720/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `92% <0%> (ø)` | :arrow_up: |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/8720/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `74.73% <0%> (ø)` | :arrow_up: |
| [superset/views/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/8720/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==) | `60.52% <0%> (ø)` | :arrow_up: |
| [superset/translations/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/8720/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdHJhbnNsYXRpb25zL3V0aWxzLnB5) | `87.5% <0%> (ø)` | :arrow_up: |
| [superset/views/log/views.py](https://codecov.io/gh/apache/incubator-superset/pull/8720/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvbG9nL3ZpZXdzLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/8720/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `96.12% <0%> (ø)` | :arrow_up: |
| ... and [12 more](https://codecov.io/gh/apache/incubator-superset/pull/8720/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8720?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8720?src=pr&el=footer). Last update [6c130b3...1aa94dc](https://codecov.io/gh/apache/incubator-superset/pull/8720?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org