[jira] [Commented] (FLINK-9063) Possible SpillableSubpartitionTest testSpillFinishedBufferConsumers test failure

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-9063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413773#comment-16413773 ] 

ASF GitHub Bot commented on FLINK-9063:
---------------------------------------

GitHub user pnowojski opened a pull request:

    https://github.com/apache/flink/pull/5765

    [FLINK-9063] Fix SpillableSubpartitionTest testSpillFinishedBufferConsumers

    testSpillFinishedBufferConsumers was incorrectly manually closing the BufferConsumer
    after passing it's ownership to the ResultSubpartition. This was leading to a race
    conditions with AsynchronousBufferFileWriter.
    
    This is a change in tests that improves stability.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes / **no**)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
      - The S3 file system connector: (yes / **no** / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pnowojski/flink f9063

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5765.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5765
    
----

----


> Possible SpillableSubpartitionTest testSpillFinishedBufferConsumers test failure
> --------------------------------------------------------------------------------
>
>                 Key: FLINK-9063
>                 URL: https://issues.apache.org/jira/browse/FLINK-9063
>             Project: Flink
>          Issue Type: Bug
>          Components: Network
>            Reporter: Piotr Nowojski
>            Assignee: Piotr Nowojski
>            Priority: Blocker
>             Fix For: 1.5.0
>
>
> {code:java}
> Tests run: 21, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.872 sec <<< FAILURE! - in org.apache.flink.runtime.io.network.partition.SpillableSubpartitionTest
> testSpillFinishedBufferConsumers(org.apache.flink.runtime.io.network.partition.SpillableSubpartitionTest) Time elapsed: 0.028 sec <<< ERROR!
> org.apache.flink.shaded.netty4.io.netty.util.IllegalReferenceCountException: refCnt: 0, decrement: 1
> at org.apache.flink.shaded.netty4.io.netty.buffer.AbstractReferenceCountedByteBuf.release(AbstractReferenceCountedByteBuf.java:101)
> at org.apache.flink.runtime.io.network.buffer.NetworkBuffer.recycleBuffer(NetworkBuffer.java:146)
> at org.apache.flink.runtime.io.network.buffer.BufferConsumer.close(BufferConsumer.java:110)
> at org.apache.flink.runtime.io.network.partition.SpillableSubpartitionTest.testSpillFinishedBufferConsumers(SpillableSubpartitionTest.java:679)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)