[jira] [Commented] (VELOCITY-815) MapGetExecutor is very slow

["Nathan Bubna (Commented) (JIRA)" <de...@velocity.apache.org>]

    [ https://issues.apache.org/jira/browse/VELOCITY-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185792#comment-13185792 ] 

Nathan Bubna commented on VELOCITY-815:
---------------------------------------

Patches are great.  Can you attach screenshots of the before/after performance output?
                
> MapGetExecutor is very slow
> ---------------------------
>
>                 Key: VELOCITY-815
>                 URL: https://issues.apache.org/jira/browse/VELOCITY-815
>             Project: Velocity
>          Issue Type: Bug
>          Components: Engine
>    Affects Versions: 1.7.x, 2.x
>            Reporter: Oswaldo Hernandez
>              Labels: perfomance
>
> When MapGetExecutor is instantiated by the UberspectImpl it iterates through all the interfaces implemented by the object's Class to figure out whether it's a java.util.Map 
> This could be replaced by an instance of test on the object received by the Uberspect which would be much faster. We noticed this as a hotspot after upgrading to 1.6 through our Performance Tests JProfiler output.
> I am happy to provide a patch for this, it would be nice to get this on the maintenance branch as well if possible, so that we don't have to maintain a fork until we upgrade.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org