[jira] [Commented] (FOP-2324) [PATCH] Character not found in AFP font but no warning is issued

["simon steiner (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FOP-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15814886#comment-15814886 ] 

simon steiner commented on FOP-2324:
------------------------------------

Can we see fop.xconf?

> [PATCH] Character not found in AFP font but no warning is issued
> ----------------------------------------------------------------
>
>                 Key: FOP-2324
>                 URL: https://issues.apache.org/jira/browse/FOP-2324
>             Project: FOP
>          Issue Type: Improvement
>          Components: font/unqualified
>    Affects Versions: trunk
>            Reporter: Seifeddine Dridi
>            Priority: Minor
>             Fix For: trunk
>
>         Attachments: patch.diff
>
>
> I noticed that the AFP font system never files a warning whenever a character was not found in the font, unlike font systems for other output formats where a warning is always displayed whenever FOP detects a possible error.
> Apparently, this is mainly happening because there is no defined mapping between Unicode values and font code points for AFP, as can be seen in CharacterSet.mapChar(). That's why I propose to change it to:
>     public char mapChar(char c) {
>         //TODO This is not strictly correct but we'll let it be for the moment
>         if (this.encoder.canEncode(c)) {
>             return c;
>         }
>         return 0;
>     }
> So we can check later in AbstractOutlineFont.mapChar() whenever a character was found or not and display a warning if necessary.
> Any thoughts?
> Thanks



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)