You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gora.apache.org by "Jaechang Nam (JIRA)" <ji...@apache.org> on 2016/12/18 15:43:58 UTC
[jira] [Updated] (GORA-499) Potential NPE issue
[ https://issues.apache.org/jira/browse/GORA-499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jaechang Nam updated GORA-499:
------------------------------
Description:
Dear Gora developers
In recent got repositiry, I've found the following lines in gora-cassandra/src/main/java/org/apache/gora/cassandra/store/CassandraClient.java.
It seems readOpConsLvl or writeOpConsLvl is null, there could be NullPointerException as the comparison operator is "||" rather using "&&". I have no idea if this is an actual bug but just reporting. Thanks!
<pre>
String opConsisLvl = (readOpConsLvl!=null || !readOpConsLvl.isEmpty())?readOpConsLvl:DEFAULT_HECTOR_CONSIS_LEVEL;
ccl.setDefaultReadConsistencyLevel(HConsistencyLevel.valueOf(opConsisLvl));
LOG.debug("Hector read consistency configured to '" + opConsisLvl + "'.");
opConsisLvl = (writeOpConsLvl!=null || !writeOpConsLvl.isEmpty())?writeOpConsLvl:DEFAULT_HECTOR_CONSIS_LEVEL;
</pre>
was:
Dear Gora developers
In recent got repositiry, I've found the following lines in gora-cassandra/src/main/java/org/apache/gora/cassandra/store/CassandraClient.java.
It seems readOpConsLvl or writeOpConsLvl is null, there could be NullPointerException as the comparison operator is "||" rather using "&&". I have no idea if this is an actual bug but just reporting. Thanks!
String opConsisLvl = (readOpConsLvl!=null || !readOpConsLvl.isEmpty())?readOpConsLvl:DEFAULT_HECTOR_CONSIS_LEVEL;
ccl.setDefaultReadConsistencyLevel(HConsistencyLevel.valueOf(opConsisLvl));
LOG.debug("Hector read consistency configured to '" + opConsisLvl + "'.");
opConsisLvl = (writeOpConsLvl!=null || !writeOpConsLvl.isEmpty())?writeOpConsLvl:DEFAULT_HECTOR_CONSIS_LEVEL;
> Potential NPE issue
> -------------------
>
> Key: GORA-499
> URL: https://issues.apache.org/jira/browse/GORA-499
> Project: Apache Gora
> Issue Type: Bug
> Reporter: Jaechang Nam
> Priority: Minor
>
> Dear Gora developers
> In recent got repositiry, I've found the following lines in gora-cassandra/src/main/java/org/apache/gora/cassandra/store/CassandraClient.java.
> It seems readOpConsLvl or writeOpConsLvl is null, there could be NullPointerException as the comparison operator is "||" rather using "&&". I have no idea if this is an actual bug but just reporting. Thanks!
> <pre>
> String opConsisLvl = (readOpConsLvl!=null || !readOpConsLvl.isEmpty())?readOpConsLvl:DEFAULT_HECTOR_CONSIS_LEVEL;
> ccl.setDefaultReadConsistencyLevel(HConsistencyLevel.valueOf(opConsisLvl));
> LOG.debug("Hector read consistency configured to '" + opConsisLvl + "'.");
> opConsisLvl = (writeOpConsLvl!=null || !writeOpConsLvl.isEmpty())?writeOpConsLvl:DEFAULT_HECTOR_CONSIS_LEVEL;
> </pre>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)