You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Sergey Nuyanzin (Jira)" <ji...@apache.org> on 2023/02/02 09:10:00 UTC
[jira] [Resolved] (FLINK-28946) Remove RexSimplify together with calcite upgrade
[ https://issues.apache.org/jira/browse/FLINK-28946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sergey Nuyanzin resolved FLINK-28946.
-------------------------------------
Resolution: Fixed
There is already a PR to fix it under https://issues.apache.org/jira/browse/FLINK-29237
so close it
> Remove RexSimplify together with calcite upgrade
> ------------------------------------------------
>
> Key: FLINK-28946
> URL: https://issues.apache.org/jira/browse/FLINK-28946
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / API
> Reporter: Sergey Nuyanzin
> Priority: Major
>
> As mentioned in {{org.apache.calcite.rex.RexSimplify}} comment
> {noformat}
> * <p>Copied to fix Calcite 1.26 bugs, should be removed for the next Calcite upgrade.
> *
> * <p>Changes (line numbers are from the original RexSimplify file):
> *
> * <ol>
> * <li>CALCITE-4364 & FLINK-19811: Line 1307, Line 1764, Line 2638 ~ Line 2656.
> * <li>CALCITE-4446 & FLINK-22015: Line 2542 ~ Line 2548, Line 2614 ~ Line 2619.
> * </ol>
> {noformat}
> at https://github.com/apache/flink/blob/master/flink-table/flink-table-planner/src/main/java/org/apache/calcite/rex/RexSimplify.java#L73-L78
> both https://issues.apache.org/jira/browse/CALCITE-4364 and https://issues.apache.org/jira/browse/CALCITE-4446 are in 1.27+
--
This message was sent by Atlassian Jira
(v8.20.10#820010)