[GitHub] [skywalking] wu-sheng commented on a change in pull request #4528: Fix profile trace not match when change the entry operationId/Name

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #4528: Fix profile trace not match when change the entry operationId/Name
URL: https://github.com/apache/skywalking/pull/4528#discussion_r393425250
 
 

 ##########
 File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/TracingContext.java
 ##########
 @@ -353,6 +353,12 @@ public AbstractSpan createEntrySpan(final String operationName) {
         final AbstractSpan parentSpan = peek();
         final int parentSpanId = parentSpan == null ? -1 : parentSpan.getSpanId();
         if (parentSpan != null && parentSpan.isEntry()) {
+            /**
+             * Only add the profiling recheck on change entry span operationId/Name.
+             * Because Change name only happen on entry span.
+             * Exit and local span will check need profiling on construct the context.
+             */
 
 Review comment:
   Already reword this comment.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services