You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Nikolay Tikhonov (JIRA)" <ji...@apache.org> on 2017/11/21 10:30:00 UTC

[jira] [Comment Edited] (IGNITE-6949) Cleanup OLS code

    [ https://issues.apache.org/jira/browse/IGNITE-6949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16260543#comment-16260543 ] 

Nikolay Tikhonov edited comment on IGNITE-6949 at 11/21/17 10:29 AM:
---------------------------------------------------------------------

[~zaleslaw],
Thank you for your contribution! I've looked at the changes and still see some code style issues. For example 
* extra space in imports (SparseBlockDistributedMatrix file);
* CacheUtils#reduce has incorrect alignments;

[~chief],
Please, double check this changes again and help [~zaleslaw] with it. 


was (Author: ntikhonov):
[~zaleslaw],
Thank you for your contribution! I've looked at the changes and still see some code style issues. For example 
* extra space in imports (SparseBlockDistributedMatrix file);
* CacheUtils#reduce has incorrect alignments;
[~chief],
Please, double check this changes again and help [~zaleslaw] with it. 

> Cleanup OLS code
> ----------------
>
>                 Key: IGNITE-6949
>                 URL: https://issues.apache.org/jira/browse/IGNITE-6949
>             Project: Ignite
>          Issue Type: Bug
>          Components: ml
>            Reporter: Yury Babak
>            Assignee: Aleksey Zinoviev
>             Fix For: 2.4
>
>
> We want fix wrong styles like wildcards in imports, unnecessary empty lines, missed empty lines and if-else blocks format in OLS related files.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)