You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/11/16 15:02:35 UTC

[GitHub] StephanEwen commented on a change in pull request #7098: [FLINK-10869] [build] Update S3 tests to reference new access key environment variables.

StephanEwen commented on a change in pull request #7098: [FLINK-10869] [build] Update S3 tests to reference new access key environment variables.
URL: https://github.com/apache/flink/pull/7098#discussion_r234235828
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/common_s3.sh
 ##########
 @@ -68,8 +68,8 @@ function s3_setup {
   trap s3_cleanup EXIT
 
   cp $FLINK_DIR/opt/flink-s3-fs-hadoop-*.jar $FLINK_DIR/lib/
-  echo "s3.access-key: $ARTIFACTS_AWS_ACCESS_KEY" >> "$FLINK_DIR/conf/flink-conf.yaml"
 
 Review comment:
   I don't know all the implication of changing/removing these variables in bash scripts ;-)
   It is also orthogonal to the change here, I would like to leave this for a dedicated cleanup setp

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services