You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2011/12/20 04:46:00 UTC

DO NOT REPLY [Bug 52371] New: Methods in HTTPSampler2 now require PostMethod instead of HttpMethodBase

https://issues.apache.org/bugzilla/show_bug.cgi?id=52371

             Bug #: 52371
           Summary: Methods in HTTPSampler2 now require PostMethod instead
                    of HttpMethodBase
           Product: JMeter
           Version: 2.5.1
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: regression
          Priority: P2
         Component: HTTP
        AssignedTo: issues@jmeter.apache.org
        ReportedBy: lauri.h.lehtinen@gmail.com
    Classification: Unclassified


A custom sampler we've been using extends HTTPSampler2. I started looking into
why it no longer worked with JMeter 2.5.1 (I upgraded from 2.4, so this may
have been introduced in 2.5), and tracked it down to some changes in the super
class (HTTPSampler2).

A closer look revealed that in several cases, the method signatures changed,
and now require a PostMethod instead of HttpMethodBase which our sampler needs
to be able to pass in. The method implementations themselves in HTTPSampler2,
however, seem to delegate to methods that in their turn accept any HttpMethod.

Examples are these methods: setupConnection, saveConnectionCookies,
getResponseHeaders, getConnectionHeaders.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 52371] API Incompatibility :Methods in HTTPSampler2 now require PostMethod instead of HttpMethodBase

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52371

Sebb <se...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #1 from Sebb <se...@apache.org> 2011-12-20 11:56:45 UTC ---
Thanks for the report; now fixed. Reverted to HttpMethod interface except for
setUpConnection which requires the HttpMethodBase abstract class.

URL: http://svn.apache.org/viewvc?rev=1221212&view=rev
Log:
Bug 52371 - API Incompatibility - Methods in HTTPSampler2 now require
PostMethod instead of HttpMethod[Base]. Reverted to original types.

Modified:
  
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSampler2.java
   jmeter/trunk/xdocs/changes.xml

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 52371] API Incompatibility :Methods in HTTPSampler2 now require PostMethod instead of HttpMethodBase

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52371

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |p.mouawad@ubik-ingenierie.c
                   |                            |om
            Summary|Methods in HTTPSampler2 now |API Incompatibility
                   |require PostMethod instead  |:Methods in HTTPSampler2
                   |of HttpMethodBase           |now require PostMethod
                   |                            |instead of HttpMethodBase

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.