[jira] Updated: (THRIFT-857) tests run by "make install" fail if generators are disabled

["Bruce Lowekamp (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruce Lowekamp updated THRIFT-857:
----------------------------------

    Attachment: check-requested-generator.patch

Ran into this problem again testing some of the new code in other issues.   Wrote this to restrict the test for namespace declarations to only check the namespace if the generator has been requested on the command line.  Very minimal testing, but it worked in getting the build to finish with only the cpp generator built.


> tests run by "make install" fail if generators are disabled
> -----------------------------------------------------------
>
>                 Key: THRIFT-857
>                 URL: https://issues.apache.org/jira/browse/THRIFT-857
>             Project: Thrift
>          Issue Type: Bug
>          Components: Test Suite
>    Affects Versions: 0.4
>         Environment: mac os
>            Reporter: Bruce Lowekamp
>            Priority: Minor
>         Attachments: check-requested-generator.patch, generator-subnamespace.patch
>
>
> configuring with generators disabled (configure --disable-gen-java, for example) produces a failed build because the tests run by "make install" require the java, cpp, rb, perl, csharp, and js generators.  
> I would personally favor either removing those --disble-gen options altogether, or adding a warning message in the configure --help output that disabling those generators is not recommended/will cause test failure.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.