[GitHub] [calcite] hsyuan commented on a change in pull request #1247: [CALCITE-3089] Deprecate EquiJoin

[GitBox <gi...@apache.org>]

hsyuan commented on a change in pull request #1247: [CALCITE-3089] Deprecate EquiJoin
URL: https://github.com/apache/calcite/pull/1247#discussion_r289590087
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/rel/core/JoinInfo.java
 ##########
 @@ -40,14 +40,16 @@
  * {@link org.apache.calcite.rel.core.EquiJoin}.</p>
  *
  * @see Join#analyzeCondition() */
-public abstract class JoinInfo {
+public class JoinInfo {
   public final ImmutableIntList leftKeys;
   public final ImmutableIntList rightKeys;
+  public final RexNode nonEqui;
 
   /** Creates a JoinInfo. */
-  protected JoinInfo(ImmutableIntList leftKeys, ImmutableIntList rightKeys) {
+  protected JoinInfo(ImmutableIntList leftKeys, ImmutableIntList rightKeys, RexNode nonEqui) {
     this.leftKeys = Objects.requireNonNull(leftKeys);
     this.rightKeys = Objects.requireNonNull(rightKeys);
+    this.nonEqui = nonEqui;
     assert leftKeys.size() == rightKeys.size();
 
 Review comment:
   nonEquiConditions might be better.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services