[GitHub] [pulsar] Jason918 edited a comment on issue #12616: [BUG]KOP failed to get partition offset

[GitBox <gi...@apache.org>]

Jason918 edited a comment on issue #12616:
URL: https://github.com/apache/pulsar/issues/12616#issuecomment-966785848


   I mean `lastConfirmedEntry` is init as "(currentLedger, -1)" in this method, if we have no other ledgers.
   
   https://github.com/apache/pulsar/blob/98e2c66a7b2d5fd42641527cd9ad6c3b497d65c7/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java#L478
   
   In the case above that all ledgers are deleted in `internalTrimLedgers`, lastConfirmedEntry is like "(lastDeleteedLedger, someEntryId)", points to a previous existed but deleted position.
   But if the topic reload to maybe another broker, the `lastConfirmedEntry` would changed to "(newCreatedLedger, -1)".
   During the situation shift, no new message was produced, but the `lastConfirmedEntry` was changed.
   It's a little confusing, right? 
   
   And in my understanding, if we update `lastConfirmedEntry` in `internalTrimLedgers`, it should works for the other methods. it's the consist with the latter case with reload.
   
   @BewareMyPower 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org