[GitHub] [iceberg] pan3793 commented on a change in pull request #2574: Build: Support overwrite maven repo by gradle properties

[GitBox <gi...@apache.org>]

pan3793 commented on a change in pull request #2574:
URL: https://github.com/apache/iceberg/pull/2574#discussion_r629457819



##########
File path: deploy.gradle
##########
@@ -113,8 +113,8 @@ subprojects {
         // upload to the releases repository using ./gradlew -Prelease publish
         def apacheSnapshotsRepoUrl = 'https://repository.apache.org/content/repositories/snapshots'
         def apacheReleasesRepoUrl = 'https://repository.apache.org/service/local/staging/deploy/maven2'
-        def snapshotsRepoUrl = project.hasProperty('mavenSnapshotsRepo') ? project.property('mavenSnapshotsRepo') : "$apacheSnapshotsRepoUrl"
-        def releasesRepoUrl = project.hasProperty('mavenReleasesRepo') ? project.property('mavenReleasesRepo') : "$apacheReleasesRepoUrl"
+        def snapshotsRepoUrl = project.hasProperty('mavenSnapshotsRepo') ? "$mavenSnapshotsRepo" : "$apacheSnapshotsRepoUrl"

Review comment:
       Overwrite `snapshotsRepo` by `-PmavenSnapshotsRepo`? Seems not work for me.
   
   As my understand, before only handle `mavenUser` and `mavenPassword` by `-P` or local properties but hardcode repo urls.
   
   > Groovy and Gradle still hold a lot of mysteries for me
   
   Big +1




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org