You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/05/06 02:53:31 UTC
[GitHub] [spark] manuzhang opened a new pull request #28457: [SPARK-31646][SHUFFLE] Remove unused registeredConnections counter from ShuffleMetrics
manuzhang opened a new pull request #28457:
URL: https://github.com/apache/spark/pull/28457
### What changes were proposed in this pull request?
Remove unused `registeredConnections` counter from `ExternalBlockHandler#ShuffleMetrics`
### Why are the changes needed?
It's `registeredConnections` counter created in `TransportContext` that's really counting the numbers and it's misleading for people who want to add new metrics like `registeredConnections`.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Add UTs to ensure all expected metrics are registered for `ExternalShuffleService` and `YarnShuffleService`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28457: [SPARK-31646][SHUFFLE] Remove unused registeredConnections counter from ShuffleMetrics
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28457:
URL: https://github.com/apache/spark/pull/28457#issuecomment-625557756
**[Test build #122419 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122419/testReport)** for PR 28457 at commit [`cc2eb00`](https://github.com/apache/spark/commit/cc2eb000bddcdbfa7c5ce7953306957d63136720).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28457: [SPARK-31646][SHUFFLE] Remove unused registeredConnections counter from ShuffleMetrics
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28457:
URL: https://github.com/apache/spark/pull/28457#issuecomment-624416908
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28457: [SPARK-31646][SHUFFLE] Remove unused registeredConnections counter from ShuffleMetrics
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28457:
URL: https://github.com/apache/spark/pull/28457#issuecomment-625558081
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28457: [SPARK-31646][SHUFFLE] Remove unused registeredConnections counter from ShuffleMetrics
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28457:
URL: https://github.com/apache/spark/pull/28457#issuecomment-625450894
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28457: [SPARK-31646][SHUFFLE] Remove unused registeredConnections counter from ShuffleMetrics
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28457:
URL: https://github.com/apache/spark/pull/28457#issuecomment-625525058
**[Test build #122413 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122413/testReport)** for PR 28457 at commit [`81c4fa4`](https://github.com/apache/spark/commit/81c4fa4f4343ce9d2afcc59965385aecf2f34c4f).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28457: [SPARK-31646][SHUFFLE] Remove unused registeredConnections counter from ShuffleMetrics
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28457:
URL: https://github.com/apache/spark/pull/28457#issuecomment-625450515
**[Test build #122413 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122413/testReport)** for PR 28457 at commit [`81c4fa4`](https://github.com/apache/spark/commit/81c4fa4f4343ce9d2afcc59965385aecf2f34c4f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28457: [SPARK-31646][SHUFFLE] Remove unused registeredConnections counter from ShuffleMetrics
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28457:
URL: https://github.com/apache/spark/pull/28457#issuecomment-625447810
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28457: [SPARK-31646][SHUFFLE] Remove unused registeredConnections counter from ShuffleMetrics
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28457:
URL: https://github.com/apache/spark/pull/28457#issuecomment-625519172
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28457: [SPARK-31646][SHUFFLE] Remove unused registeredConnections counter from ShuffleMetrics
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28457:
URL: https://github.com/apache/spark/pull/28457#issuecomment-624416695
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28457: [SPARK-31646][SHUFFLE] Remove unused registeredConnections counter from ShuffleMetrics
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28457:
URL: https://github.com/apache/spark/pull/28457#issuecomment-625518695
**[Test build #122419 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122419/testReport)** for PR 28457 at commit [`cc2eb00`](https://github.com/apache/spark/commit/cc2eb000bddcdbfa7c5ce7953306957d63136720).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28457: [SPARK-31646][SHUFFLE] Remove unused registeredConnections counter from ShuffleMetrics
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28457:
URL: https://github.com/apache/spark/pull/28457#issuecomment-625519172
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28457: [SPARK-31646][SHUFFLE] Remove unused registeredConnections counter from ShuffleMetrics
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28457:
URL: https://github.com/apache/spark/pull/28457#issuecomment-625558083
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122419/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28457: [SPARK-31646][SHUFFLE] Remove unused registeredConnections counter from ShuffleMetrics
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28457:
URL: https://github.com/apache/spark/pull/28457#issuecomment-625525787
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28457: [SPARK-31646][SHUFFLE] Remove unused registeredConnections counter from ShuffleMetrics
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28457:
URL: https://github.com/apache/spark/pull/28457#issuecomment-625518695
**[Test build #122419 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122419/testReport)** for PR 28457 at commit [`cc2eb00`](https://github.com/apache/spark/commit/cc2eb000bddcdbfa7c5ce7953306957d63136720).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28457: [SPARK-31646][SHUFFLE] Remove unused registeredConnections counter from ShuffleMetrics
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #28457:
URL: https://github.com/apache/spark/pull/28457#discussion_r421759581
##########
File path: core/src/test/scala/org/apache/spark/deploy/ExternalShuffleServiceMetricsSuite.scala
##########
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.deploy
+
+import scala.collection.JavaConverters._
+
+import org.apache.spark.{SecurityManager, SparkConf, SparkFunSuite}
+import org.apache.spark.util.Utils
+
+class ExternalShuffleServiceMetricsSuite extends SparkFunSuite {
+
+ var sparkConf: SparkConf = _
+ var externalShuffleService: ExternalShuffleService = _
+
+ override def beforeAll(): Unit = {
+ super.beforeAll()
+ sparkConf = new SparkConf()
+ sparkConf.set("spark.shuffle.service.enabled", "true")
Review comment:
nit. Shall we add `import org.apache.spark.internal.config.SHUFFLE_SERVICE_ENABLED`, do the following?
```scala
- sparkConf.set("spark.shuffle.service.enabled", "true")
+ sparkConf.set(SHUFFLE_SERVICE_ENABLED, true)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28457: [SPARK-31646][SHUFFLE] Remove unused registeredConnections counter from ShuffleMetrics
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28457:
URL: https://github.com/apache/spark/pull/28457#issuecomment-625564526
In this PR, `ExternalShuffleServiceDbSuite` passed success in the last two commits. However, after merging, Jenkins seems to complain currently. I'm monitoring the Jenkins jobs now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28457: [SPARK-31646][SHUFFLE] Remove unused registeredConnections counter from ShuffleMetrics
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28457:
URL: https://github.com/apache/spark/pull/28457#issuecomment-625525787
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28457: [SPARK-31646][SHUFFLE] Remove unused registeredConnections counter from ShuffleMetrics
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28457:
URL: https://github.com/apache/spark/pull/28457#issuecomment-625449624
Thank you for making a PR, @manuzhang .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28457: [SPARK-31646][SHUFFLE] Remove unused registeredConnections counter from ShuffleMetrics
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28457:
URL: https://github.com/apache/spark/pull/28457#issuecomment-625558081
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28457: [SPARK-31646][SHUFFLE] Remove unused registeredConnections counter from ShuffleMetrics
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28457:
URL: https://github.com/apache/spark/pull/28457#issuecomment-625450515
**[Test build #122413 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122413/testReport)** for PR 28457 at commit [`81c4fa4`](https://github.com/apache/spark/commit/81c4fa4f4343ce9d2afcc59965385aecf2f34c4f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28457: [SPARK-31646][SHUFFLE] Remove unused registeredConnections counter from ShuffleMetrics
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28457:
URL: https://github.com/apache/spark/pull/28457#issuecomment-625450894
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28457: [SPARK-31646][SHUFFLE] Remove unused registeredConnections counter from ShuffleMetrics
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28457:
URL: https://github.com/apache/spark/pull/28457#issuecomment-624416908
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28457: [SPARK-31646][SHUFFLE] Remove unused registeredConnections counter from ShuffleMetrics
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28457:
URL: https://github.com/apache/spark/pull/28457#issuecomment-624416695
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org