You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2018/05/28 14:58:06 UTC
Review Request 67342: Added `cgroups/*` into the agent flag
`--isolation`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67342/
-----------------------------------------------------------
Review request for mesos and Gilbert Song.
Repository: mesos
Description
-------
Added `cgroups/*` into the agent flag `--isolation`.
Diffs
-----
docs/configuration/agent.md af0c0405da54bad748dcf4de1af0d1cad2dd4661
src/slave/flags.cpp 23d9bb1ca9bc7451afae69f39c25605660612c2e
Diff: https://reviews.apache.org/r/67342/diff/1/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 67342: Added `cgroups/all` into the agent flag
`--isolation`.
Posted by Qian Zhang <zh...@gmail.com>.
> On May 31, 2018, 8 a.m., Gilbert Song wrote:
> > Could we also update the mesos-containerizer.md and have a new file to introduce the semantic, since people may rely on that document as reference.
Created https://issues.apache.org/jira/browse/MESOS-8973 for that.
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67342/#review204092
-----------------------------------------------------------
On May 30, 2018, 9:04 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67342/
> -----------------------------------------------------------
>
> (Updated May 30, 2018, 9:04 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Bugs: MESOS-7691
> https://issues.apache.org/jira/browse/MESOS-7691
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `cgroups/all` into the agent flag `--isolation`.
>
>
> Diffs
> -----
>
> docs/configuration/agent.md e0aaf2c15023d1cb24e16b02f948b3d3848be57a
> src/slave/flags.cpp 23d9bb1ca9bc7451afae69f39c25605660612c2e
>
>
> Diff: https://reviews.apache.org/r/67342/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 67342: Added `cgroups/all` into the agent flag
`--isolation`.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67342/#review204092
-----------------------------------------------------------
Could we also update the mesos-containerizer.md and have a new file to introduce the semantic, since people may rely on that document as reference.
docs/configuration/agent.md
Line 1033 (original), 1033 (patched)
<https://reviews.apache.org/r/67342/#comment286481>
Should we mention the overwrite semantic?
docs/configuration/agent.md
Line 1034 (original), 1034 (patched)
<https://reviews.apache.org/r/67342/#comment286478>
s/in/on/g?
docs/configuration/agent.md
Lines 1035 (patched)
<https://reviews.apache.org/r/67342/#comment286479>
s/in/by/g?
src/slave/flags.cpp
Line 132 (original), 132-133 (patched)
<https://reviews.apache.org/r/67342/#comment286480>
ditto.
- Gilbert Song
On May 30, 2018, 6:04 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67342/
> -----------------------------------------------------------
>
> (Updated May 30, 2018, 6:04 a.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Bugs: MESOS-7691
> https://issues.apache.org/jira/browse/MESOS-7691
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `cgroups/all` into the agent flag `--isolation`.
>
>
> Diffs
> -----
>
> docs/configuration/agent.md e0aaf2c15023d1cb24e16b02f948b3d3848be57a
> src/slave/flags.cpp 23d9bb1ca9bc7451afae69f39c25605660612c2e
>
>
> Diff: https://reviews.apache.org/r/67342/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 67342: Added `cgroups/all` into the agent flag
`--isolation`.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67342/#review204433
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On May 31, 2018, 8:20 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67342/
> -----------------------------------------------------------
>
> (Updated May 31, 2018, 8:20 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Bugs: MESOS-7691
> https://issues.apache.org/jira/browse/MESOS-7691
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `cgroups/all` into the agent flag `--isolation`.
>
>
> Diffs
> -----
>
> docs/configuration/agent.md e0aaf2c15023d1cb24e16b02f948b3d3848be57a
> src/slave/flags.cpp 23d9bb1ca9bc7451afae69f39c25605660612c2e
>
>
> Diff: https://reviews.apache.org/r/67342/diff/3/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 67342: Added `cgroups/all` into the agent flag
`--isolation`.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67342/
-----------------------------------------------------------
(Updated June 1, 2018, 11:20 a.m.)
Review request for mesos and Gilbert Song.
Changes
-------
Addressed review comments.
Bugs: MESOS-7691
https://issues.apache.org/jira/browse/MESOS-7691
Repository: mesos
Description
-------
Added `cgroups/all` into the agent flag `--isolation`.
Diffs (updated)
-----
docs/configuration/agent.md e0aaf2c15023d1cb24e16b02f948b3d3848be57a
src/slave/flags.cpp 23d9bb1ca9bc7451afae69f39c25605660612c2e
Diff: https://reviews.apache.org/r/67342/diff/3/
Changes: https://reviews.apache.org/r/67342/diff/2-3/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 67342: Added `cgroups/all` into the agent flag
`--isolation`.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67342/
-----------------------------------------------------------
(Updated May 30, 2018, 9:04 p.m.)
Review request for mesos and Gilbert Song.
Summary (updated)
-----------------
Added `cgroups/all` into the agent flag `--isolation`.
Bugs: MESOS-7691
https://issues.apache.org/jira/browse/MESOS-7691
Repository: mesos
Description (updated)
-------
Added `cgroups/all` into the agent flag `--isolation`.
Diffs (updated)
-----
docs/configuration/agent.md e0aaf2c15023d1cb24e16b02f948b3d3848be57a
src/slave/flags.cpp 23d9bb1ca9bc7451afae69f39c25605660612c2e
Diff: https://reviews.apache.org/r/67342/diff/2/
Changes: https://reviews.apache.org/r/67342/diff/1-2/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 67342: Added `cgroups/*` into the agent flag
`--isolation`.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67342/
-----------------------------------------------------------
(Updated May 28, 2018, 10:59 p.m.)
Review request for mesos and Gilbert Song.
Bugs: MESOS-7691
https://issues.apache.org/jira/browse/MESOS-7691
Repository: mesos
Description
-------
Added `cgroups/*` into the agent flag `--isolation`.
Diffs
-----
docs/configuration/agent.md af0c0405da54bad748dcf4de1af0d1cad2dd4661
src/slave/flags.cpp 23d9bb1ca9bc7451afae69f39c25605660612c2e
Diff: https://reviews.apache.org/r/67342/diff/1/
Testing
-------
sudo make check
Thanks,
Qian Zhang