You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2024/03/28 23:08:34 UTC

[I] `parquet / Build wasm32 (pull_request)` CI check failing on main [arrow-rs]

alamb opened a new issue, #5565:
URL: https://github.com/apache/arrow-rs/issues/5565

   **Describe the bug**
   `parquet / Build wasm32 (pull_request)` CI check is failing on main , evenwi
   
   **To Reproduce**
   Make a PR with no code changes, for example https://github.com/apache/arrow-rs/pull/5564
   
   It fails like https://github.com/apache/arrow-rs/actions/runs/8474125669/job/23219908414?pr=5564
   
   ```
   Run cargo build -p parquet --target wasm32-unknown-unknown
     cargo build -p parquet --target wasm3[2](https://github.com/apache/arrow-rs/actions/runs/8474125669/job/23219908414?pr=5564#step:6:2)-unknown-unknown
     shell: sh -e {0}
     env:
       RUSTFLAGS: -C debuginfo=1
       RUST_BACKTRACE: 1
      Compiling autocfg v1.2.0
      Compiling libm v0.2.8
      Compiling libc v0.2.15[3](https://github.com/apache/arrow-rs/actions/runs/8474125669/job/23219908414?pr=5564#step:6:3)
   ...
   Compiling arrow-cast v51.0.0 (/__w/arrow-rs/arrow-rs/arrow-cast)
   The following warnings were emitted during compilation:
   
   warning: zstd-sys@2.0.10+zstd.1.5.6: In file included from zstd/lib/common/zstd_common.c:18:
   warning: zstd-sys@2.0.10+zstd.1.5.6: In file included from zstd/lib/common/zstd_internal.h:35:
   warning: zstd-sys@2.0.10+zstd.1.5.6: zstd/lib/common/xxhash.h:3157:22: error: called object type 'int' is not a function or function pointer
   warning: zstd-sys@2.0.10+zstd.1.5.6:     XXH_STATIC_ASSERT(sizeof(XXH32_canonical_t) == sizeof(XXH32_hash_t));
   warning: zstd-sys@2.0.10+zstd.1.5.6:     ~~~~~~~~~~~~~~~~~^
   warning: zstd-sys@2.0.10+zstd.1.5.6: zstd/lib/common/xxhash.h:3600:22: error: called object type 'int' is not a function or function pointer
   warning: zstd-sys@2.0.10+zstd.1.5.6:     XXH_STATIC_ASSERT(sizeof(XXH[64](https://github.com/apache/arrow-rs/actions/runs/8474125669/job/23219908414?pr=5564#step:6:65)_canonical_t) == sizeof(XXH64_hash_t));
   warning: zstd-sys@2.0.10+zstd.1.5.6:     ~~~~~~~~~~~~~~~~~^
   warning: zstd-sys@2.0.10+zstd.1.5.6: 2 errors generated.
   ...
   ```
   
   
   **Expected behavior**
   CI checks should pass when no code is chanegd
   
   
   **Additional context**
   Reported by @XiangpengHao  on https://github.com/apache/arrow-rs/pull/5564


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] `parquet / Build wasm32 (pull_request)` CI check failing on main [arrow-rs]

Posted by "kylebarron (via GitHub)" <gi...@apache.org>.
kylebarron commented on issue #5565:
URL: https://github.com/apache/arrow-rs/issues/5565#issuecomment-2026497242

   The shim defining `XXH_STATIC_ASSERT` is [pretty old](https://github.com/gyscos/zstd-rs/blame/e470f0021d25cd5f79431acba0b7456301c00b82/zstd-safe/zstd-sys/build.rs#L146). So my guess is that zstd.1.5.5 -> zstd.1.5.6 used `XXH_STATIC_ASSERT` in a new way that's incompatible with the shim?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] `parquet / Build wasm32 (pull_request)` CI check failing on main [arrow-rs]

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on issue #5565:
URL: https://github.com/apache/arrow-rs/issues/5565#issuecomment-2061309400

   `label_issue.py` automatically added labels {'arrow'} from #5525


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] `parquet / Build wasm32 (pull_request)` CI check failing on main [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #5565:
URL: https://github.com/apache/arrow-rs/issues/5565#issuecomment-2027068022

   Thank you @kylebarron  and @Jefffrey  for debugging and fixing this issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] `parquet / Build wasm32 (pull_request)` CI check failing on main [arrow-rs]

Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on issue #5565:
URL: https://github.com/apache/arrow-rs/issues/5565#issuecomment-2026428095

   (Just some random notes as I investigate a bit)
   
   Success: https://github.com/apache/arrow-rs/actions/runs/8441272186/job/23120055830
   
   - Runner Image Version: 20240317.1.0
   
   Failure: https://github.com/apache/arrow-rs/actions/runs/8466052041/job/23193980665
   
   - Runner Image Version: 20240324.2.0
   
   Also of note: https://github.com/gyscos/zstd-rs/issues/269


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] `parquet / Build wasm32 (pull_request)` CI check failing on main [arrow-rs]

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold closed issue #5565: `parquet / Build wasm32 (pull_request)` CI check failing on main
URL: https://github.com/apache/arrow-rs/issues/5565


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] `parquet / Build wasm32 (pull_request)` CI check failing on main [arrow-rs]

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on issue #5565:
URL: https://github.com/apache/arrow-rs/issues/5565#issuecomment-2061309453

   `label_issue.py` automatically added labels {'parquet'} from #5567


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org