You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/09/01 20:11:47 UTC
[GitHub] [accumulo] keith-turner opened a new pull request #2258: Prevents compaction when tablet does not know of files
keith-turner opened a new pull request #2258:
URL: https://github.com/apache/accumulo/pull/2258
I noticed when looking into #2239 that when a compaction job starts and reserves files that there is no check to ensure the tablet still has those files. I think this race condition is unlikely to occur, but not impossible. This PR add a check for this. This check prevents unnecessary work from occurring. The code is correct without the check in that it would currently fail after the compaction if this situation were to occur.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] EdColeman commented on pull request #2258: Prevents compaction when tablet does not know of files
Posted by GitBox <gi...@apache.org>.
EdColeman commented on pull request #2258:
URL: https://github.com/apache/accumulo/pull/2258#issuecomment-912605360
Asking for clarification - what happens if the check fails? Is it rescheduled or is that left up to the caller that scheduled the compaction?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] keith-turner merged pull request #2258: Prevents compaction when tablet does not know of files
Posted by GitBox <gi...@apache.org>.
keith-turner merged pull request #2258:
URL: https://github.com/apache/accumulo/pull/2258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] keith-turner commented on pull request #2258: Prevents compaction when tablet does not know of files
Posted by GitBox <gi...@apache.org>.
keith-turner commented on pull request #2258:
URL: https://github.com/apache/accumulo/pull/2258#issuecomment-914572025
> Asking for clarification - what happens if the check fails? Is it rescheduled or is that left up to the caller that scheduled the compaction?
@EdColeman tablets are periodically examined and a compaction planner is asked to create zero or more compaction jobs (an immutable object the describes compaction work to do). These jobs are queued to run later. When the job actually goes to run, maybe things have changed (like this PR is checking for) in which case the job is ignored. Later when the tablet is examined again, new jobs will be created that incorporate the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org