[jira] Commented: (DERBY-3156) Convert testing of derby error stream to JUnit

["Daniel John Debrunner (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539621 ] 

Daniel John Debrunner commented on DERBY-3156:
----------------------------------------------

The test contains a number of static fields, do they all need to be static? Static fields will lead to problems and are not typical in JUnit tests, each test fixture(testXXX method)   is an unique instance of a class so either instance fields should be used or even better just pass the information around. E.g. the setUp method will be called for every fixture, so there's no real benefit to storing information in fields since they will not be shared across fixtures.

Can you comment the reason the test doesn't run with a security manager.

> Convert testing of derby error stream to JUnit
> ----------------------------------------------
>
>                 Key: DERBY-3156
>                 URL: https://issues.apache.org/jira/browse/DERBY-3156
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>            Reporter: Vemund Østgaard
>            Assignee: Vemund Østgaard
>            Priority: Minor
>         Attachments: 3156-diff, 3156-diff.stat
>
>
> Convert the tests that are related to derby error stream properties and functionality.
> Seems to be these two tests:
> lang/logStream.java 
> lang/errorStream.java

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.