[GitHub] [pulsar-client-cpp] shibd commented on a diff in pull request #222: Fix TableViewTest.testCreateTableView flaky test.

["shibd (via GitHub)" <gi...@apache.org>]

shibd commented on code in PR #222:
URL: https://github.com/apache/pulsar-client-cpp/pull/222#discussion_r1141537787


##########
tests/TableViewTest.cc:
##########
@@ -58,7 +58,7 @@ TEST(TableViewTest, testCreateTableView) {
     // Test async create and close the client during the process.
     Latch latch(1);
     client.createTableViewAsync(
-        topic, tableViewConfiguration, [&latch](Result result, const TableView& tableView) {
+        topic, {.schemaInfo = schemaInfo}, [&latch](Result result, const TableView& tableView) {

Review Comment:
   Because this is to close the tableView during asynchronous creation. 
   
   I thought about it for a moment, and it is also problematic to modify it like this. It is possible to receive `result == ResultOk`
   
   This test is intended to cover that it is possible to close during asynchronous creation. But this can be a lot of cases, so it does not make sense. So I removed that section of the test



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org