You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "walterddr (via GitHub)" <gi...@apache.org> on 2023/05/13 18:12:48 UTC
[GitHub] [pinot] walterddr opened a new pull request, #10764: [multisage] fix set op issue
walterddr opened a new pull request, #10764:
URL: https://github.com/apache/pinot/pull/10764
it should return 1 block at a time when consuming from left input.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] xiangfu0 commented on a diff in pull request #10764: [multisage] fix set op issue
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on code in PR #10764:
URL: https://github.com/apache/pinot/pull/10764#discussion_r1194308329
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/SetOperator.java:
##########
@@ -112,36 +110,29 @@ protected void constructRightBlockSet() {
}
block = _rightChildOperator.nextBlock();
}
- _isRightBlockConsumed = true;
+ _isRightSetBuilt = true;
}
- protected TransferableBlock constructResultBlockSet() {
- _resultRowBlock.clear();
- // First time initialization.
- if (_currentLeftBlock == null) {
- _currentLeftBlock = _leftChildOperator.nextBlock();
+ protected TransferableBlock constructResultBlockSet(TransferableBlock leftBlock) {
+ List<Object[]> rows = new ArrayList<>();
+ if (leftBlock.isErrorBlock()) {
+ _upstreamErrorBlock = leftBlock;
+ return _upstreamErrorBlock;
}
- while (!_currentLeftBlock.isEndOfStreamBlock()) {
- if (_currentLeftBlock.getType() == DataBlock.Type.METADATA) {
- _currentLeftBlock = _leftChildOperator.nextBlock();
- continue;
+ if (leftBlock.isNoOpBlock() || leftBlock.isSuccessfulEndOfStreamBlock()) {
+ if (!leftBlock.getResultMetadata().isEmpty()) {
Review Comment:
why empty code block?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr merged pull request #10764: [multisage] fix set op issue
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr merged PR #10764:
URL: https://github.com/apache/pinot/pull/10764
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #10764: [multisage] fix set op issue
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10764:
URL: https://github.com/apache/pinot/pull/10764#issuecomment-1546730621
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10764?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#10764](https://app.codecov.io/gh/apache/pinot/pull/10764?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (6a98002) into [master](https://app.codecov.io/gh/apache/pinot/commit/3a8c57802059c26a4b8733414407be769f732816?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (3a8c578) will **decrease** coverage by `54.96%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #10764 +/- ##
=============================================
- Coverage 68.66% 13.71% -54.96%
+ Complexity 6463 439 -6024
=============================================
Files 2143 2098 -45
Lines 115200 113194 -2006
Branches 17356 17173 -183
=============================================
- Hits 79106 15528 -63578
- Misses 30512 96397 +65885
+ Partials 5582 1269 -4313
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `?` | |
| unittests1 | `?` | |
| unittests2 | `13.71% <0.00%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/pinot/pull/10764?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ache/pinot/query/runtime/operator/SetOperator.java](https://app.codecov.io/gh/apache/pinot/pull/10764?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtcXVlcnktcnVudGltZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvcXVlcnkvcnVudGltZS9vcGVyYXRvci9TZXRPcGVyYXRvci5qYXZh) | `0.00% <0.00%> (-82.61%)` | :arrow_down: |
... and [1671 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/10764/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org