You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/11/01 15:12:00 UTC
[jira] [Commented] (DISPATCH-2247) "Received MAU from an unknown
router" error message must include unknown router id
[ https://issues.apache.org/jira/browse/DISPATCH-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17436889#comment-17436889 ]
ASF GitHub Bot commented on DISPATCH-2247:
------------------------------------------
ted-ross commented on a change in pull request #1414:
URL: https://github.com/apache/qpid-dispatch/pull/1414#discussion_r740289212
##########
File path: src/router_core/modules/mobile_sync/mobile.c
##########
@@ -690,8 +690,24 @@ static void qcm_mobile_sync_on_mau_CT(qdrm_mobile_sync_t *msync, qd_parsed_field
// Tell the python router about the new mobile sequence
//
qdr_post_set_mobile_seq_CT(msync->core, router->mask_bit, mobile_seq);
- } else
- qd_log(msync->log, QD_LOG_ERROR, "Received MAU from an unknown router");
+ } else {
+ //
+ // There is a possibility here that router_id is null but that is fine. We want to print it out either way
+ // which will help us in debugging.
+ //
+ char *r_id = 0;
+ bool free_rid = false;
Review comment:
You don't need the free_rid thing. It is safe to call 'free' on a null pointer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> "Received MAU from an unknown router" error message must include unknown router id
> ----------------------------------------------------------------------------------
>
> Key: DISPATCH-2247
> URL: https://issues.apache.org/jira/browse/DISPATCH-2247
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Routing Engine
> Affects Versions: 1.17.0
> Reporter: Ganesh Murthy
> Priority: Major
> Fix For: 1.18.0
>
>
> Sometimes the router prints out the following error -
> {noformat}
> Received MAU from an unknown router {noformat}
> It would be nice if it print out the router id received in the MAU, like so
> {noformat}
> Received MAU from an unknown router with id QDR.A {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org