You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@beam.apache.org by "Kenneth Knowles (Jira)" <ji...@apache.org> on 2022/06/03 21:13:00 UTC

[jira] [Commented] (BEAM-3882) Make StateRequestHandler::accept interface idiomatic.

    [ https://issues.apache.org/jira/browse/BEAM-3882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17547102#comment-17547102 ] 

Kenneth Knowles commented on BEAM-3882:
---------------------------------------

This issue has been migrated to https://github.com/apache/beam/issues/18888

> Make StateRequestHandler::accept interface idiomatic.
> -----------------------------------------------------
>
>                 Key: BEAM-3882
>                 URL: https://issues.apache.org/jira/browse/BEAM-3882
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-core
>            Reporter: Axel Magnuson
>            Priority: P3
>              Labels: triaged
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> StateRequestHandler was based on some Dataflow SDK source code that does not conform to Beam coding conventions.  In particular, the accept method takes its return value as a parameter, which is a code smell.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)