You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/10/07 15:40:00 UTC

[jira] [Updated] (ARROW-6711) [C++] Consolidate Filter and Expression classes

     [ https://issues.apache.org/jira/browse/ARROW-6711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ASF GitHub Bot updated ARROW-6711:
----------------------------------
    Labels: dataset pull-request-available  (was: dataset)

> [C++] Consolidate Filter and Expression classes
> -----------------------------------------------
>
>                 Key: ARROW-6711
>                 URL: https://issues.apache.org/jira/browse/ARROW-6711
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Ben Kietzman
>            Assignee: Ben Kietzman
>            Priority: Major
>              Labels: dataset, pull-request-available
>             Fix For: 1.0.0
>
>
> There is unnecessary boilerplate required when using the Filter/Expression classes. Filter is no longer necessary; it (and FilterVector) can be replaced with Expression. Expression is sufficiently general that it can be subclassed to provide any custom functionality which would have been added through a GenericFilter (add some tests for this).
> Additionally rows within RecordBatches yielded from a scan are not currently filtered using Expression::Evaluate(). (Add tests ensuring both row filtering and pruning obey Kleene logic)
> Add some comments on the mechanism of {{Assume()}} too, and refactor it not to return a Result (its failure modes are covered by {{Validate()}})



--
This message was sent by Atlassian Jira
(v8.3.4#803005)