You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "lidavidm (via GitHub)" <gi...@apache.org> on 2023/03/09 17:57:14 UTC

[GitHub] [arrow] lidavidm commented on a diff in pull request #34249: GH-34248: [C++] Add an order_by node

lidavidm commented on code in PR #34249:
URL: https://github.com/apache/arrow/pull/34249#discussion_r1131390426


##########
cpp/src/arrow/compute/exec/options.h:
##########
@@ -402,6 +402,14 @@ class ARROW_EXPORT OrderBySinkNodeOptions : public SinkNodeOptions {
   SortOptions sort_options;
 };
 
+class ARROW_EXPORT OrderByNodeOptions : public ExecNodeOptions {

Review Comment:
   nit: docstring?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org