You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2015/11/18 07:27:37 UTC

svn commit: r1714941 - in /pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff: CFFParser.java IndexData.java

Author: tilman
Date: Wed Nov 18 06:27:37 2015
New Revision: 1714941

URL: http://svn.apache.org/viewvc?rev=1714941&view=rev
Log:
PDFBOX-3082: reduce memory on IndexData, as suggested by Tom Callahan

Modified:
    pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CFFParser.java
    pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/IndexData.java

Modified: pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CFFParser.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CFFParser.java?rev=1714941&r1=1714940&r2=1714941&view=diff
==============================================================================
--- pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CFFParser.java (original)
+++ pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CFFParser.java Wed Nov 18 06:27:37 2015
@@ -163,7 +163,7 @@ public class CFFParser
         index.initData(dataSize);
         for (int i = 0; i < dataSize; i++)
         {
-            index.setData(i, input.readCard8());
+            index.setData(i, (byte) input.readCard8());
         }
         return index;
     }

Modified: pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/IndexData.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/IndexData.java?rev=1714941&r1=1714940&r2=1714941&view=diff
==============================================================================
--- pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/IndexData.java (original)
+++ pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/IndexData.java Wed Nov 18 06:27:37 2015
@@ -25,7 +25,7 @@ public class IndexData
 {
     private final int count;
     private final int[] offset;
-    private int[] data;
+    private byte[] data;
 
     /**
      * Constructor.
@@ -44,7 +44,7 @@ public class IndexData
         byte[] bytes = new byte[length];
         for (int i = 0; i < length; i++)
         {
-            bytes[i] = (byte) data[offset[index] - 1 + i];
+            bytes[i] = data[offset[index] - 1 + i];
         }
         return bytes;
     }
@@ -92,7 +92,7 @@ public class IndexData
      */
     public void initData(int dataSize) 
     {
-        data = new int[dataSize];
+        data = new byte[dataSize];
     }
     
     /**
@@ -100,7 +100,7 @@ public class IndexData
      * @param index the index of the data value
      * @param value the given data value
      */
-    public void setData(int index, int value) 
+    public void setData(int index, byte value) 
     {
         data[index] = value;
     }