[GitHub] [spark] zhenlineo commented on a change in pull request #35701: [SPARK-38378][SQL] Refactoring of the ANTLR grammar definition into separate Parser and Lexer files

[GitBox <gi...@apache.org>]

zhenlineo commented on a change in pull request #35701:
URL: https://github.com/apache/spark/pull/35701#discussion_r817533441



##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/SQLKeywordSuite.scala
##########
@@ -30,11 +30,15 @@ import org.apache.spark.sql.catalyst.util.fileToString
 trait SQLKeywordUtils extends SparkFunSuite with SQLHelper {
 
   val sqlSyntaxDefs = {
-    val sqlBasePath = {
+    val sqlBaseParserPath =

Review comment:
       We still have `ansiNonReserved` `nonReserved` defined in parser file. So the test need to include both files.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org