[superset] 02/03: proper schema

[hu...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

hugh pushed a commit to branch hugh/move-extra-fields
in repository https://gitbox.apache.org/repos/asf/superset.git

commit b92c9b333c68b302c8cc87ba9053485315b39a0c
Author: hughhhh <hu...@gmail.com>
AuthorDate: Sun Jun 13 12:02:46 2021 -0400

    proper schema
---
 .../src/views/CRUD/data/database/types.ts              | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/superset-frontend/src/views/CRUD/data/database/types.ts b/superset-frontend/src/views/CRUD/data/database/types.ts
index 2ec6266..e0246f8 100644
--- a/superset-frontend/src/views/CRUD/data/database/types.ts
+++ b/superset-frontend/src/views/CRUD/data/database/types.ts
@@ -49,21 +49,23 @@ export type DatabaseObject = {
   // Security
   encrypted_extra?: string;
   server_cert?: string;
+  allow_csv_upload?: boolean;
+  impersonate_user?: boolean;
 
   // Extra
   extra_json?: {
+    engine_params?: {};
+    metadata_params?: {};
     metadata_cache_timeout?: {
-      schema_cache_timeout?: string; // in Performance
-      table_cache_timeout?: string; // in Performance
+      schema_cache_timeout?: number; // in Performance
+      table_cache_timeout?: number; // in Performance
     }; // No field, holds schema and table timeout
-    cost_query_enabled?: boolean; // in SQL Lab
     allows_virtual_table_explore?: boolean; // in SQL Lab
-    schemas_allowed_for_csv_upload?: string; // in Security
-    impersonate_user?: boolean; // in Security
-    allow_csv_upload?: boolean; // in Security
+    schemas_allowed_for_csv_upload?: []; // in Security
     version?: string;
-    metadata_params?: {};
-    engine_params?: {};
+
+    // todo: ask beto where this should live
+    cost_query_enabled?: boolean; // in SQL Lab
   };
   extra?: string;
 };