You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/03/23 12:29:46 UTC
[GitHub] [ignite] Sega76 opened a new pull request #9906: IGNITE-16728: [ducktests] Change logger to log4j2
Sega76 opened a new pull request #9906:
URL: https://github.com/apache/ignite/pull/9906
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] anton-vinogradov commented on a change in pull request #9906: IGNITE-16728: [ducktests] Change logger to log4j2
Posted by GitBox <gi...@apache.org>.
anton-vinogradov commented on a change in pull request #9906:
URL: https://github.com/apache/ignite/pull/9906#discussion_r834122343
##########
File path: config/ignite-log4j2.xml
##########
@@ -28,6 +28,12 @@
<PatternLayout pattern="[%d{ISO8601}][%-5p][%t][%c{1}]%notEmpty{[%markerSimpleName]} %m%n"/>
</Console>
+ <File name="CONSISTENCY" fileName="${sys:IGNITE_HOME}/work/log/consistency.log">
Review comment:
Should not be added to relular log, I think.
##########
File path: config/ignite-log4j2.xml
##########
@@ -28,6 +28,12 @@
<PatternLayout pattern="[%d{ISO8601}][%-5p][%t][%c{1}]%notEmpty{[%markerSimpleName]} %m%n"/>
</Console>
+ <File name="CONSISTENCY" fileName="${sys:IGNITE_HOME}/work/log/consistency.log">
Review comment:
Should not be added to regular log, I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] timoninmaxim commented on a change in pull request #9906: IGNITE-16728: [ducktests] Change logger to log4j2
Posted by GitBox <gi...@apache.org>.
timoninmaxim commented on a change in pull request #9906:
URL: https://github.com/apache/ignite/pull/9906#discussion_r834115242
##########
File path: config/ignite-log4j2.xml
##########
@@ -28,6 +28,12 @@
<PatternLayout pattern="[%d{ISO8601}][%-5p][%t][%c{1}]%notEmpty{[%markerSimpleName]} %m%n"/>
</Console>
+ <File name="CONSISTENCY" fileName="${sys:IGNITE_HOME}/work/log/consistency.log">
Review comment:
Why not APPEND here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Sega76 commented on a change in pull request #9906: IGNITE-16728: [ducktests] Change logger to log4j2
Posted by GitBox <gi...@apache.org>.
Sega76 commented on a change in pull request #9906:
URL: https://github.com/apache/ignite/pull/9906#discussion_r834083707
##########
File path: config/ignite-log4j2.xml
##########
@@ -28,6 +28,12 @@
<PatternLayout pattern="[%d{ISO8601}][%-5p][%t][%c{1}]%notEmpty{[%markerSimpleName]} %m%n"/>
</Console>
+ <File name="CONSISTENCY" fileName="${sys:IGNITE_HOME}/work/log/consistency.log">
Review comment:
for ignitetest.tests.control_utility.consistency_test.ConsistencyTest.test_logging.ignite_version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Sega76 commented on a change in pull request #9906: IGNITE-16728: [ducktests] Change logger to log4j2
Posted by GitBox <gi...@apache.org>.
Sega76 commented on a change in pull request #9906:
URL: https://github.com/apache/ignite/pull/9906#discussion_r834122826
##########
File path: config/ignite-log4j2.xml
##########
@@ -28,6 +28,12 @@
<PatternLayout pattern="[%d{ISO8601}][%-5p][%t][%c{1}]%notEmpty{[%markerSimpleName]} %m%n"/>
</Console>
+ <File name="CONSISTENCY" fileName="${sys:IGNITE_HOME}/work/log/consistency.log">
Review comment:
append is true by default
https://logging.apache.org/log4j/2.x/manual/appenders.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] timoninmaxim merged pull request #9906: IGNITE-16728: [ducktests] Change logger to log4j2
Posted by GitBox <gi...@apache.org>.
timoninmaxim merged pull request #9906:
URL: https://github.com/apache/ignite/pull/9906
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Sega76 commented on a change in pull request #9906: IGNITE-16728: [ducktests] Change logger to log4j2
Posted by GitBox <gi...@apache.org>.
Sega76 commented on a change in pull request #9906:
URL: https://github.com/apache/ignite/pull/9906#discussion_r834087910
##########
File path: modules/ducktests/tests/ignitetest/services/utils/ignite_aware.py
##########
@@ -286,7 +286,7 @@ def event_time(evt_message, node):
match = re.match("^\\[[^\\[]+\\]", stdout)
- return datetime.strptime(match.group(), "[%Y-%m-%d %H:%M:%S,%f]") if match else None
+ return datetime.strptime(match.group(), "[%Y-%m-%dT%H:%M:%S,%f]") if match else None
Review comment:
we use pattern [%d{ISO8601}][%-5p][%t][%c{1}] %m%n
it contains 'T'
https://en.wikipedia.org/wiki/ISO_8601
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] anton-vinogradov commented on a change in pull request #9906: IGNITE-16728: [ducktests] Change logger to log4j2
Posted by GitBox <gi...@apache.org>.
anton-vinogradov commented on a change in pull request #9906:
URL: https://github.com/apache/ignite/pull/9906#discussion_r834122343
##########
File path: config/ignite-log4j2.xml
##########
@@ -28,6 +28,12 @@
<PatternLayout pattern="[%d{ISO8601}][%-5p][%t][%c{1}]%notEmpty{[%markerSimpleName]} %m%n"/>
</Console>
+ <File name="CONSISTENCY" fileName="${sys:IGNITE_HOME}/work/log/consistency.log">
Review comment:
Should not be added to regular log, I think.
Looks like solved by `additivity="false"` some lines later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org