[jira] [Commented] (CONNECTORS-257) Input-able response lifetime for Active Directory authority

["Karl Wright (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CONNECTORS-257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13108454#comment-13108454 ] 

Karl Wright commented on CONNECTORS-257:
----------------------------------------

The patch looks technically correct.  A couple of things I recommend changing, however:
(1) A point of English: Let's call it "Cache lifetime" in the UI and in the configuration data, not "Response lifetime".
(2) It's probably better to parse the cache lifetime into a numeric member variable (a long) at either connect() or getSession() time.  At getSession() time you can report an error if the number is incorrect.
(3) When you parse the cache lifetime, you need to be careful because the parameter may be null (e.g. from an older installation).


> Input-able response lifetime for Active Directory authority
> -----------------------------------------------------------
>
>                 Key: CONNECTORS-257
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-257
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Active Directory authority
>    Affects Versions: ManifoldCF 0.1, ManifoldCF 0.2, ManifoldCF 0.3
>            Reporter: Shinichiro Abe
>            Assignee: Shinichiro Abe
>            Priority: Minor
>             Fix For: ManifoldCF 0.4
>
>         Attachments: CONNECTORS-257-1.patch
>
>
> The access tokens are cached for one minute, and up to 1000 different
> users' access tokens will be cached at any one time.
> The access token's cache per username remains idle before expiring.
> Its expiration time depends response lifetime, and 
> expiration time is updated after looking up the cache.
> Currently response lifetime is 1 minute.
> Since I want not to access Active Directory frequently, 
> I make this response lifetime to be input-able for users.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira